New issue
Advanced search Search tips

Issue 754771 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Username and Passwords autofill using 1Password extension are not recognized when submitting Sign in form.

Project Member Reported by jdhakshinamoor@chromium.org, Aug 11 2017

Issue description

App Version:  61.0.3163.40 Beta
iOS Version:  11.0 beta 4
Device: iPhone 6, iPad4 
URL:  Walmart.com

Steps to reproduce:
  1. Launch the app
  2. Navigate to the URL
  3. Hover onto the Menu icon
  4. Tap on Sign in link
  5.  Tap on Share
  6.  Tap on 1Password
  7.  Type the password for 1Password
  8. Tap on Walmart in 1Password app

Observed results:
Notice that Username and Password are filled in correctly but they are not recognized correctly when submitting the Signin form

Expected results:
Username and Password should be recognized correctly when submitting the Signin form
 
Number of times you were able to reproduce:  5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox:  no, Safari:  no
Bug reproducible on current stable build (App Version, iOS Version): Yes, M60
Bug reproducible on the current beta channel build (App Version, iOS Version):  Yes, M61
Bug reproducible on Chrome desktop?  No


Link to video/image:
https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mTm9hTW9Iajl6cFU


 

Comment 1 by edchin@chromium.org, Aug 14 2017

Owner: pkl@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by pkl@chromium.org, Aug 14 2017

On walmart.com, the email address and passwords are filled correctly, but if user taps on "Sign In" button, the red "(!) Email address is required." and "(!) Password is required." error messages came up. It appears as if the user did not type in anything. However, if user just tap on the 2 fields, then Sign In button, the username/password are recognized.

It looks as if the web page detected that the user did not manually entered the text fields.

Note that 1Password and Safari worked together properly.

Comment 3 by pkl@chromium.org, Aug 15 2017

Cc: vasi...@chromium.org
Status: Started (was: Assigned)
Thanks to vasilii@ who debugged this with me. When forms are filled using JavaScript, some events are not triggered. Certain web sites (e.g. walmart.com) that are looking for these events will not consider the form to be "filled" and thus report an error at validation.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33070c63b05f0261b545d69dacacfa05502abc5

commit f33070c63b05f0261b545d69dacacfa05502abc5
Author: Peter K. Lee <pkl@chromium.org>
Date: Tue Aug 15 17:37:36 2017

Force .focus() on username/password fields when auto-filling

When forms are filled using JavaScript, some events are not triggered.
Certain web sites (e.g. walmart.com) that are looking for these events
will not consider the form to be "filled" and thus report an error at
validation.

Bug:  754771 
Change-Id: I0adcc3a8be1655b6dceda0239620ffd8049f3522
Reviewed-on: https://chromium-review.googlesource.com/615363
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494431}
[modify] https://crrev.com/f33070c63b05f0261b545d69dacacfa05502abc5/ios/chrome/browser/passwords/resources/password_controller.js

Comment 5 by pkl@chromium.org, Aug 15 2017

Labels: M-62
Status: Fixed (was: Started)
This will be fixed in M62.
This fixes walmart.com, however, there may be other sites that are still broken. See comment 3.
Status: Verified (was: Fixed)
Verified on 62.0.3193.0 Canary build in iPad Mini(iOS 11 beta 7) and iPhone 7(iOS 10.3.3)

Followed the steps mentioned in comment 0, able to sign in with no error message, looks good.

Sign in to add a comment