New issue
Advanced search Search tips

Issue 754767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 355145



Sign in to add a comment

PasswordManagerBrowserTestBase.VerifyPasswordGenerationUpload flaky on Mac

Project Member Reported by fs...@chromium.org, Aug 11 2017

Issue description

https://test-results.appspot.com/dashboards/flakiness_dashboard.html?#tests=PasswordManagerBrowserTestBase.VerifyPasswordGenerationUpload

Check that both Mac boths have a history of failing this test.

For example:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/45779

It seems to happen consistently on Mac release, but only sometimes on builder bot. If it happens more often, I'll disable it, but please take a look nonetheless. :)
 
[ RUN      ] PasswordManagerBrowserTestBase.VerifyPasswordGenerationUpload
Xlib:  extension "RANDR" missing on display ":99".
[11850:11850:0818/051957.989305:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[11950:11950:0818/051958.146287:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11850:12077:0818/051958.290276:WARNING:embedded_test_server.cc(225)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/password_manager_test_base.cc:594: Failure
      Expected: expected_value
      Which is: "password"
To be equal to: return_value
      Which is: ""
element_id = password_field
[11850:11850:0818/051958.555702:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] PasswordManagerBrowserTestBase.VerifyPasswordGenerationUpload, where TypeParam =  and GetParam() =  (820 ms)

The flakiness is caused by checking the plain text password value. We should wait for it to change instead like we did in https://chromium-review.googlesource.com/c/570162
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b4f9f8c9b7b50d7e83c808ab16073d7e29112c

commit f2b4f9f8c9b7b50d7e83c808ab16073d7e29112c
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Aug 22 11:30:44 2017

Fix VerifyPasswordGenerationUpload browser test.

The CL fixes the test similar to https://chromium-review.googlesource.com/c/570162. We need to wait for the password to be autofilled instead of checking it right away.

Bug:  754767 
Change-Id: I96da2d8185d40a3103fb5e71ae35ee20eab91712
Reviewed-on: https://chromium-review.googlesource.com/621691
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496280}
[modify] https://crrev.com/f2b4f9f8c9b7b50d7e83c808ab16073d7e29112c/chrome/browser/password_manager/password_manager_browsertest.cc

Blocking: 355145
Status: Fixed (was: Untriaged)

Sign in to add a comment