IPCSyncChannelTest.RestrictedDispatch failed on Fuchsia in ipc_tests |
||||||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8642 [00009.438] 02834.02895> [ RUN ] IPCSyncChannelTest.RestrictedDispatch [00009.438] 02834.02895> [3:1741421360:0811/041544.306385:8289862:ERROR:ipc_sync_channel_unittest.cc(1279)] Send failed to dispatch incoming message on same channel [00009.438] 02834.02895> [3:1741421360:0811/041544.332067:8315090:ERROR:ipc_sync_channel_unittest.cc(1301)] Send dispatched message from restricted channel [00009.438] 02834.02895> ../../ipc/ipc_sync_channel_unittest.cc:1378: Failure [00009.438] 02834.02895> Expected: 4 [00009.438] 02834.02895> To be equal to: success [00009.438] 02834.02895> Which is: 2 [00009.438] 02834.02895> [ FAILED ] IPCSyncChannelTest.RestrictedDispatch (487 ms)
,
Sep 1 2017
Inspecting the test code, it appears that it is making the assumption that all Chrome IPC is serialized via the IPC thread, so that if we post a Task to the IPC thread and signal an event, then when we see the event the IPC must have been received by the peer (see https://cs.chromium.org/chromium/src/ipc/ipc_sync_channel_unittest.cc?type=cs&l=1189). Now that Chrome IPC runs on Mojo, the Mojo and Chrome IPC threads differ: - Mojo's is a TestIOThread created at https://cs.chromium.org/chromium/src/ipc/run_all_unittests.cc?dr&l=21 - Chrome's is a member of the Worker test helper class (see https://cs.chromium.org/chromium/src/ipc/ipc_sync_channel_unittest.cc?gsn=ipc_thread&l=251). So I think that this test is now inherently racey, and needs updating to post a message to the Worker ipc_thread_ that then posts a message to the (process-wide) Mojo IPC thread to signal the event.
,
Sep 1 2017
Except that this is in-process IPC, which I think Mojo can shortcut to pass directly between threads?
,
Sep 18 2017
Yeah, Mojo's IPC thread is never relevant for in-process message passing.
,
Feb 26 2018
,
Mar 6 2018
,
May 23 2018
,
Jul 22
No sign of this flaking any more, so closing as obsolete. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by scottmg@chromium.org
, Aug 16 2017