New issue
Advanced search Search tips

Issue 754751 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocked on:
issue v8:6700


Participants' hotlists:
Hotlist-AsmJsParser


Sign in to add a comment

33.0% regression in v8/Emscripten-asm_wasm/Bullet on Nexus5 at 47277:47277

Project Member Reported by mtrofin@chromium.org, Aug 11 2017

Issue description

Performance dashboard identified a 33.0% regression in v8/Emscripten-asm_wasm/Bullet on Nexus5 at revision range 47277:47277. Graph: https://chromeperf.appspot.com/report?masters=internal.client.v8&bots=Nexus5&tests=v8%2FEmscripten-asm_wasm%2FBullet&checked=Bullet%2CBullet_ref%2Cref&rev=47277

 
Status: Assigned (was: Untriaged)
v8:6700 should address this issue.
Blockedon: v8:6700
Cc: rmcilroy@chromium.org
Components: Blink>JavaScript
Labels: -Pri-2 Pri-1
Issue 755209 has been merged into this issue.
Regressions associated with this bug:   
  https://chromeperf.appspot.com/group_report?bug_id=754751
Issue 755210 has been merged into this issue.
Issue 755149 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/313f8d3fcb71b66fcc3e3028bb87505c053e1f90

commit 313f8d3fcb71b66fcc3e3028bb87505c053e1f90
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Tue Aug 22 08:50:26 2017

[asm.js] Fix heap access validation of shift expressions.

This makes sure that shift expressions (not wrapped in parentheses) can
appear as part of the index in a valid heap access expression. Only the
last operand of a sequence of shift expressions is taken into account
when validating the heap access.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-6700
BUG= v8:6700 , chromium:754751 

Change-Id: Icc7a71bd64461da4d3daea41b995964e3dfc6dc6
Reviewed-on: https://chromium-review.googlesource.com/623811
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47497}
[modify] https://crrev.com/313f8d3fcb71b66fcc3e3028bb87505c053e1f90/src/asmjs/asm-parser.cc
[modify] https://crrev.com/313f8d3fcb71b66fcc3e3028bb87505c053e1f90/src/asmjs/asm-parser.h
[add] https://crrev.com/313f8d3fcb71b66fcc3e3028bb87505c053e1f90/test/mjsunit/regress/regress-6700.js

Status: Fixed (was: Assigned)
The change in comment #7 fixed the issue, "Bullet" is now validating as correct asm.js code. Looking at the graphs, the two recent regressions recovered and we are now at an overall improvement of around 30% across all architectures compared to two weeks ago. This is fixed.

Sign in to add a comment