New issue
Advanced search Search tips

Issue 754729 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

For autofill profile validation, add tests for non-western languages.

Project Member Reported by parastoog@chromium.org, Aug 11 2017

Issue description

Add tests for a country whose default language is a non-Western language, such as China.

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f2018a7a59b4605a839ffa52396ceb460dac08

commit f6f2018a7a59b4605a839ffa52396ceb460dac08
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Nov 07 23:31:36 2017

More Fields for Autofill Profile Validation API

-- The autofill profile validation API can now validate
   locality (like city or ..) and dependent locality 
   (like neighborhood, district or ..) fields.

-- If a field is required, it should not be left empty.
An empty required field is considered as invalid.

-- If a field is filled, 
and the rules for validating that field are available in the source,
then the field will be validated according to the rules.

-- Even if a field is not required, but it's filled and it is not
valid according to the rules in the source, the field would be marked
as invalid.

-- Unit-tests added for new fields.

-- Unit-tests added for a country with a non-Western language.

Bug:  754729 , 748223
Change-Id: Ic621aa15f1d0f5eb87b225ea33de005f85ebb4c7
Reviewed-on: https://chromium-review.googlesource.com/757078
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#514647}
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/address_validation_util.cc
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/address_validation_util_unittest.cc
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/autofill_profile_validator_unittest.cc
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/autofill_test_utils.h
[modify] https://crrev.com/f6f2018a7a59b4605a839ffa52396ceb460dac08/components/autofill/core/browser/phone_email_validation_util_unittest.cc

Status: Verified (was: Started)

Sign in to add a comment