Microdumps should contain the crash reason and address |
||
Issue descriptionAs it stands we attempt to extract this information from the debuggerd output, but sometimes (e.g. a multiprocess renderer crash) the debuggerd information is out of sync with the microdump information. We should store the correct values directly in the microdump.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/breakpad/breakpad/+/38cbbfed71efcb28931b5e4a83e3c0d4661f1548 commit 38cbbfed71efcb28931b5e4a83e3c0d4661f1548 Author: Tobias Sargeant <tobiasjs@google.com> Date: Mon Aug 14 09:49:51 2017 Add crash reason and address to microdumps. This will allow us to provide the right information for webview renderer crashes. At the moment the crash information for the browser process is captured (from the debuggerd output) instead. BUG= 754715 Change-Id: I409546311b6e38fe1cf804097c18d7bb2a015d83 Reviewed-on: https://chromium-review.googlesource.com/612381 Reviewed-by: Robert Sesek <rsesek@chromium.org> [modify] https://crrev.com/38cbbfed71efcb28931b5e4a83e3c0d4661f1548/src/client/linux/microdump_writer/microdump_writer_unittest.cc [modify] https://crrev.com/38cbbfed71efcb28931b5e4a83e3c0d4661f1548/src/client/linux/microdump_writer/microdump_writer.cc [modify] https://crrev.com/38cbbfed71efcb28931b5e4a83e3c0d4661f1548/src/client/linux/minidump_writer/linux_dumper.cc [modify] https://crrev.com/38cbbfed71efcb28931b5e4a83e3c0d4661f1548/src/client/linux/minidump_writer/linux_dumper.h
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c8f89b92430895e9c98f8540fb90f308ea47cc3 commit 3c8f89b92430895e9c98f8540fb90f308ea47cc3 Author: Tobias Sargeant <tobiasjs@google.com> Date: Wed Aug 16 20:46:02 2017 Roll src/breakpad/src/ 7a65a4734..877d207e7 (4 commits) https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/7a65a47345a8..877d207e755e $ git log 7a65a4734..877d207e7 --date=short --no-merges --format='%ad %ae %s' 2017-08-11 tobiasjs Add crash reason and address to microdumps. 2017-07-26 lv Increase maximum number of regions for minidump_stackwalk. 2017-07-11 mosescu Handle very large stack traces 2017-07-06 mosescu A couple of minor fixes Created with: roll-dep src/breakpad/src BUG= 754715 R=rsesek@chromium.org Change-Id: I8464a78d9407a872f956049a7954f81d67edeb8c Reviewed-on: https://chromium-review.googlesource.com/612954 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#494937} [modify] https://crrev.com/3c8f89b92430895e9c98f8540fb90f308ea47cc3/DEPS
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/breakpad/breakpad/+/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b commit 2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b Author: Tobias Sargeant <tobiasjs@google.com> Date: Mon Aug 21 10:19:07 2017 Add crash reason extraction to microdump processor BUG= 754715 Change-Id: I00fe62ed06dbbab4c8f6c416d56e2d444be11571 Reviewed-on: https://chromium-review.googlesource.com/621307 Reviewed-by: Robert Sesek <rsesek@chromium.org> [modify] https://crrev.com/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b/src/processor/microdump.cc [modify] https://crrev.com/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b/src/processor/microdump_processor_unittest.cc [add] https://crrev.com/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b/src/processor/testdata/microdump-withcrashreason.dmp [modify] https://crrev.com/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b/src/google_breakpad/processor/microdump.h [modify] https://crrev.com/2b3be5179e18975b4f12a9ecdf91ea08f3bb9f4b/src/processor/microdump_processor.cc
,
Aug 22 2017
,
Sep 13 2017
that last breakpad CL broke the unittests. see https://bugs.chromium.org/p/google-breakpad/issues/detail?id=746 for details. |
||
►
Sign in to add a comment |
||
Comment 1 by tobiasjs@chromium.org
, Aug 11 2017