color: Move Blink.ColorSpace.Destination histograms out of blink |
||
Issue descriptionThe histograms for display information are Blink.ColorSpace.Destination are based on the ICC profile that is used for image decoding. With color correct rendering enabled, this is always set to sRGB. These histograms have therefore not been giving useful data in a month. Fix that!
,
Aug 11 2017
Oh -- we always decode images into their own color space now -- the decision of which space to raster into is done in cc::, not blink::.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/598ce823a09c136e054cc288c0f9146e61b47c3a commit 598ce823a09c136e054cc288c0f9146e61b47c3a Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Aug 30 19:05:37 2017 color: Move ICC profile histograms from blink to gfx Histogram all new ICC profiles that are created from raw data. Do this only when creating the profile from data, not - when receiving a profile via IPC - when creating a profile from data that is already cached In histogramming the results of parsing and ICC profile, disambiguate several separate states that were previously merged. The old histogramming code would attempt to numerically approximate all channels separately, but not actually use the result. For the moment, remove this. Only approximate the combined channels. R=hubbe TBR=chrishtr (third_party/WebKit/...), holte (tools/metrics/...) Bug: 754701 Change-Id: Iee03959a8a6f96610cc3977311fcd61da5547ac7 Reviewed-on: https://chromium-review.googlesource.com/612252 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#498558} [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/tools/metrics/histograms/enums.xml [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/ui/display/mac/screen_mac.mm [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/ui/display/win/color_profile_reader.cc [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/ui/gfx/icc_profile.cc [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/ui/gfx/icc_profile.h [modify] https://crrev.com/598ce823a09c136e054cc288c0f9146e61b47c3a/ui/views/widget/desktop_aura/desktop_screen_x11.cc
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c46032ebc79565ff52ddd152018fdfefb45f4e06 commit c46032ebc79565ff52ddd152018fdfefb45f4e06 Author: Reilly Grant <reillyg@chromium.org> Date: Wed Aug 30 22:53:52 2017 Revert "color: Move ICC profile histograms from blink to gfx" This reverts commit 598ce823a09c136e054cc288c0f9146e61b47c3a. Reason for revert: Breaks content_shell. https://crbug.com/760767 Original change's description: > color: Move ICC profile histograms from blink to gfx > > Histogram all new ICC profiles that are created from raw data. Do this > only when creating the profile from data, not > - when receiving a profile via IPC > - when creating a profile from data that is already cached > > In histogramming the results of parsing and ICC profile, disambiguate > several separate states that were previously merged. > > The old histogramming code would attempt to numerically approximate > all channels separately, but not actually use the result. For the > moment, remove this. Only approximate the combined channels. > > R=​hubbe > TBR=chrishtr (third_party/WebKit/...), holte (tools/metrics/...) > > Bug: 754701 > Change-Id: Iee03959a8a6f96610cc3977311fcd61da5547ac7 > Reviewed-on: https://chromium-review.googlesource.com/612252 > Commit-Queue: ccameron chromium <ccameron@chromium.org> > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#498558} TBR=ccameron@chromium.org,hubbe@chromium.org Change-Id: I87ef06d8694d6ec6b8b2bf6123d320d4fc0b5e7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754701 Reviewed-on: https://chromium-review.googlesource.com/644153 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#498654} [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/ui/display/mac/screen_mac.mm [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/ui/display/win/color_profile_reader.cc [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/ui/gfx/icc_profile.cc [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/ui/gfx/icc_profile.h [modify] https://crrev.com/c46032ebc79565ff52ddd152018fdfefb45f4e06/ui/views/widget/desktop_aura/desktop_screen_x11.cc
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/374b6c4ce72e03d2d10eca28496b2f6cad77326d commit 374b6c4ce72e03d2d10eca28496b2f6cad77326d Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Aug 31 22:21:23 2017 Reland "color: Move ICC profile histograms from blink to gfx" This is a reland of 598ce823a09c136e054cc288c0f9146e61b47c3a Original change's description: > color: Move ICC profile histograms from blink to gfx > > Histogram all new ICC profiles that are created from raw data. Do this > only when creating the profile from data, not > - when receiving a profile via IPC > - when creating a profile from data that is already cached > > In histogramming the results of parsing and ICC profile, disambiguate > several separate states that were previously merged. > > The old histogramming code would attempt to numerically approximate > all channels separately, but not actually use the result. For the > moment, remove this. Only approximate the combined channels. > > R=hubbe > TBR=chrishtr (third_party/WebKit/...), holte (tools/metrics/...) > > Bug: 754701 > Change-Id: Iee03959a8a6f96610cc3977311fcd61da5547ac7 > Reviewed-on: https://chromium-review.googlesource.com/612252 > Commit-Queue: ccameron chromium <ccameron@chromium.org> > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#498558} R=hubbe TBR=chrishtr (third_party/WebKit/...), holte (tools/metrics/...) Bug: 754701 Change-Id: If883ef371aace58318eaf52275ca692b61e67934 Reviewed-on: https://chromium-review.googlesource.com/646580 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#499043} [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/ui/display/mac/screen_mac.mm [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/ui/display/win/color_profile_reader.cc [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/ui/gfx/icc_profile.cc [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/ui/gfx/icc_profile.h [modify] https://crrev.com/374b6c4ce72e03d2d10eca28496b2f6cad77326d/ui/views/widget/desktop_aura/desktop_screen_x11.cc
,
Sep 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by hubbe@chromium.org
, Aug 11 2017