Keep scroll position in Console when clicking on stack trace source
Reported by
kirill.m...@gmail.com,
Aug 11 2017
|
|||||
Issue description
Chrome Version : 60.0.3112.90
OS Version: OS X 10.12.6
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5: OK
Firefox 4.x: OK
IE 7/8/9:
What steps will reproduce the problem?
1. Open a page with a javascript error on it with stacktrace and many messages after it
2. Scroll to stacktrace and click on a stacktrace line to open code in Sources panel
3. Click on a Console tab
What is the expected result?
The Console should open on the same scrolling position which was before clicking on stacktrace item.
What happens instead of that?
The Console shows the last line of the Console
Please provide any additional information below. Attach a screenshot if
possible.
If I right-click on the link and open it using "Open in Sources panel" item, clicking to Console tab back works as expected, i.e. the position is preserved.
UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
,
Aug 11 2017
,
Aug 11 2017
,
Aug 11 2017
Thanks for the report. I can reproduce, it's weird that right click > "Open in sources" will preserve scroll position while regular click on a link does not. In theory they should both be detaching the console panel, but I need to investigate. In the meantime, another workaround that might be easier than right clicking is to have the drawer open with console (pressing Esc in DevTools), to see both console and sources at the same time.
,
Aug 11 2017
Hello, thanks for the hint with the open drawer, but I often work on a notebook and keeping both sources and console is not very practical - I see too little on the screen at the same time. And thanks a lot for looking into this, hope the fix won't be difficult :)
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec61e6916397b9b041798dce121a38e247ce85dd commit ec61e6916397b9b041798dce121a38e247ce85dd Author: Erik Luo <luoe@chromium.org> Date: Wed Dec 20 20:53:20 2017 DevTools: preserve console scroll position when switching tabs Bug: 754697 Change-Id: I84bb10fcaffdb334e14923a768278843277aa1b3 Reviewed-on: https://chromium-review.googlesource.com/813498 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525446} [add] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt [add] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll.js [modify] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js [modify] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/Source/devtools/front_end/console_test_runner/ConsoleTestRunner.js [modify] https://crrev.com/ec61e6916397b9b041798dce121a38e247ce85dd/third_party/WebKit/Source/devtools/front_end/ui/View.js
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f1a1eacc3d88986bf5b92d1acdc17983891834 commit 28f1a1eacc3d88986bf5b92d1acdc17983891834 Author: Erik Luo <luoe@chromium.org> Date: Wed Jan 17 04:50:02 2018 DevTools: preserve Console scrollTop when opening drawer When opening the Console drawer, the Widget system tries to restore scrollTop. However, it fails when the message viewport has no scrollbar. This CL bounds the max-height of the searchable view, so that Console scroll can be restored. Bug: 754697 Change-Id: Id4a971bc5e9e4e2549015e3c8fe7e31b074c476d Reviewed-on: https://chromium-review.googlesource.com/833501 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529613} [modify] https://crrev.com/28f1a1eacc3d88986bf5b92d1acdc17983891834/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt [modify] https://crrev.com/28f1a1eacc3d88986bf5b92d1acdc17983891834/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll.js [modify] https://crrev.com/28f1a1eacc3d88986bf5b92d1acdc17983891834/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/28f1a1eacc3d88986bf5b92d1acdc17983891834/third_party/WebKit/Source/devtools/front_end/console/consoleView.css [modify] https://crrev.com/28f1a1eacc3d88986bf5b92d1acdc17983891834/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
,
Jan 17 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jonathan.garbee@chromium.org
, Aug 11 2017Labels: -Type-Bug -OS-Mac OS-All Type-Feature
Status: Untriaged (was: Unconfirmed)