New issue
Advanced search Search tips

Issue 754645 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 770208
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Log spam on touch events with {passive:false} set

Reported by rycoche...@gmail.com, Aug 11 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Steps to reproduce the problem:
Use `element.addEventListener("touchstart", code, {passive:false})`

The console is being spammed with verbose lines:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.

What is the expected behavior?
No log spam because `{passive:false}` has been explicitly added.

What went wrong?
I have thousands of pages for education, due to not being able to know until the touch/click what is meant to happen there is no way of telling the element that it will not be able to scroll beforehand, nor can the event be passive as it may need to be cancelled. Some pages have upwards of 5k of these on them, and result in just as many completely unnecessary spam lines being written to the log. When editing the pages via the a app that can result in >100k spam lines in a matter of minutes, causing the browser tab to crash.

Did this work before? Yes 58?

Chrome version: 60.0.3112.90  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Report *once* at most per source line calling it.

If a developer has specifically set `passive:false` then stop punishing the users by causing their browsing session to crash (especially when it's school age children). We've already had to redeploy thousands of pages when they stopped working from the surprise break from the web standards by setting `passive:true` without any spam lines like this...
 

Comment 1 by l...@chromium.org, Aug 14 2017

Cc: skobes@chromium.org
Components: Blink>Scroll
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the report, that sounds really unfortunate.  I agree that at most one report per source would be better.  I will take a look.

In the meantime, are you able to avoid a tab crash by hiding Verbose level messages?  The console has a toolbar dropdown that should allow you to uncheck 'Verbose' to hide them.

@Blink>Scroll, has there already been discussion about not showing the Deprecation message when {passive: false} is explicitly set?  cc'ing skobes@, who may know.

Comment 2 by skobes@chromium.org, Aug 14 2017

Cc: dtapu...@chromium.org pfeldman@chromium.org
It looks like pfeldman added this in http://crrev.com/451102.

Comment 3 by l...@chromium.org, Oct 11 2017

Mergedinto: 770208
Status: Duplicate (was: Assigned)
Merging with a duplicate that has been fixed.  Thank you dtapuska@

Sign in to add a comment