New issue
Advanced search Search tips

Issue 754632 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue v8:6633



Sign in to add a comment

5.8% regression in system_health.memory_desktop at 492192:492231

Project Member Reported by jgruber@chromium.org, Aug 11 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 11 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=754632

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1b9447ece5668fbd5fe574a5c0ffe913733baba627909741e379e0f04af8d5ac


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 11 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_news/load_news_wikipedia

Revision             Result                   N
chromium@492191      12555800 +- 2046611      21      good
chromium@492231      12605733 +- 1681462      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.wikipedia system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971563716222924352


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 12 2017

Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jgruber
  Commit : 1081720532abdbfd6e767e9f39a0eb80e0164682
  Date   : Fri Aug 04 12:18:47 2017
  Subject: [regexp] Limit ATOM regexps to patterns length <= 2

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_news/load_news_wikipedia
  Change       : 5.32% | 11969097.1429 -> 12605732.5714

Revision                           Result                   N
chromium@492045                    11969097 +- 1885147      14      good
chromium@492138                    11969097 +- 1566610      14      good
chromium@492151                    12106411 +- 1132592      21      good
chromium@492157                    11931648 +- 1284238      9       good
chromium@492160                    11969097 +- 1566610      14      good
chromium@492161                    11756885 +- 605396       6       good
chromium@492161,v8@05e862f783      12043995 +- 804939       14      good
chromium@492161,v8@e91b96922e      11931648 +- 1657944      14      good
chromium@492161,v8@ea0e1e21ec      12206275 +- 1593533      21      good
chromium@492161,v8@1081720532      12568283 +- 1094387      14      bad       <--
chromium@492161,v8@f677b27b20      12406004 +- 1642078      21      bad
chromium@492162                    12455936 +- 1961706      21      bad
chromium@492185                    12643182 +- 939966       14      bad
chromium@492231                    12605733 +- 1372908      14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.wikipedia system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971545486524259632


For feedback, file a bug with component Speed>Bisection
Blocking: v8:6633
Status: Fixed (was: Assigned)
The CL has long since been reverted, see also  https://crbug.com/v8/6633#c19 .

Sign in to add a comment