New issue
Advanced search Search tips

Issue 754628 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 752017



Sign in to add a comment

Remove recovery_count

Project Member Reported by tnagel@chromium.org, Aug 11 2017

Issue description

Removing recovery_count for privacy reasons: It leaks some aspects of the long-term history of the device.

Full discussion: https://groups.google.com/a/google.com/d/topic/chromeos-privacy/jtpGpgCorKE/discussion
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/7791ed6bfc0d451bb4432ee73151cd4f2ea70a05

commit 7791ed6bfc0d451bb4432ee73151cd4f2ea70a05
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Fri Aug 11 21:36:19 2017

recovery: Remove recovery_count

recovery_count leaks some aspect of the device's long-term history.
Removing for privacy reasons.

BUG=chromium:754628
TEST=manual

Change-Id: Idbf2d9a9965e77ebd65f6b2ec8786af7cee80158
Reviewed-on: https://chromium-review.googlesource.com/612242
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/7791ed6bfc0d451bb4432ee73151cd4f2ea70a05/recovery/recovery_init.sh

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba7ffc303e6bf7c9b49a1cb715d4118a65032d6

commit 1ba7ffc303e6bf7c9b49a1cb715d4118a65032d6
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Thu Aug 17 17:49:03 2017

Obsolete Installer.Recovery.Count histogram

Superseded by Installer.Recovery.Reason.

Bug: 754628
Change-Id: Idaf55c967b496b16af1ff53fa7833b37281040c8
Reviewed-on: https://chromium-review.googlesource.com/618632
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495210}
[modify] https://crrev.com/1ba7ffc303e6bf7c9b49a1cb715d4118a65032d6/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/946023366e40df1f378dbe04b29c147dbabb97fa

commit 946023366e40df1f378dbe04b29c147dbabb97fa
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Thu Aug 17 18:31:51 2017

init: Remove recovery_count metrics

Remove the metrics_client call for the contents of the "recovery_count"
VPD key because that key has been deprecated.

BUG=chromium:754628
TEST=manual

Change-Id: I88b9f1e8b2f49ee8c6ee18a74243a0495053967a
Reviewed-on: https://chromium-review.googlesource.com/618631
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/946023366e40df1f378dbe04b29c147dbabb97fa/init/upstart/send-recovery-metrics.conf

Comment 4 by tnagel@chromium.org, Aug 25 2017

Blockedon: 752017
There's remaining code in clobber-state and cutoff.sh, but this should only be removed once clearing of RW_VPD is implemented (issue 752017) to avoid stale recovery_count VPD entries hanging around.

Sign in to add a comment