New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754606 link

Starred by 4 users
Status: Assigned
Owner:
vmi...@chromium.org
Cc:
█ jbau...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Extension popup is initially shown too small

Reported by alshaba...@yandex-team.ru, Aug 11 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 YaBrowser/17.9.0.1281 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Install an extension (e.g. LastPass)
2. Click on its icon

What is the expected behavior?
Popup is initially shown with the correct size.

What went wrong?
For the first couple of frames it's shown with a very small size.

Did this work before? N/A 

Chrome version: 60.0.3112.90  Channel: n/a
OS Version: 10
Flash Version:
https:jing.yandex-team.ru:files:kirichek:2017-08-09_1622.swf 2017-08-11 11-53-03.png
17.2 KB View Download
https:jing.yandex-team.ru:files:kirichek:2017-08-09_1622.swf 2017-08-11 11-53-41.png
39.4 KB View Download

Comment 1 by woxxom@gmail.com, Aug 11 2017 

Broken in 49.0.2590.0
Bisect info: 364887 (good) - 364903 (bad)
https://chromium.googlesource.com/chromium/src/+log/f84cab76..03447cc3?pretty=fuller
Suspecting r364897 "Resize output_rect of aggregated CompositorFrame to enable it to be drawn when resizing"

Repro:
1. unpack and install the attached extension
2. click the extension's icon in browser toolbar
3. if the bug is not obvious repeat step#2 several times with 1 second intervals
EXPECTED: only the popup is shown; no flicker
OBSERVED: a small empty rectangle is shown first for a fraction of a second; then the popup is shown

P.S. Assuming my guess at the CL is correct, the change is obviously intended but opening of the extension popup should be excluded from this to avoid unsightly flicker.
popup.zip
5.0 KB Download

Comment 2 by ligim...@chromium.org, Aug 11 2017

Labels: -Type-Bug -Pri-2 M-62 Pri-1 Type-Bug-Regression
Owner: jbau...@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to the Cl owner for further updates.

https://chromium.googlesource.com/chromium/src/+/e95e17121740b79c447cb93d0e1d07bbfc407a14

Comment 3 by jbau...@chromium.org, Aug 11 2017

Status: WontFix (was: Assigned)
The extension actually requests to be drawn at that size initially, then resizes itself to the correct size, so any fix would be in the extension itself.

I think we were getting lucky earlier - the browser compositor and renderer compositor drew the frame at the initial size, but the window was resized before it actually had a chance to be shown, so that frame was thrown away. Now we try to display that frame anyway, to avoid the case where we have no contents for the window for a long time due to continuous resizing.

Comment 4 by jbau...@chromium.org, Aug 11 2017

Cc: jbau...@chromium.org
Components: Platform>Extensions Blink>Compositing
Owner: ----
Status: Available (was: WontFix)
Actually, I'm reopening this because even if I set the initial width on the image in the demo extension it still chooses the wrong initial size for the window. I think maybe something is weird with the blink compositor sizing so it's drawing before getting the correct size.

Comment 5 by woxxom@gmail.com, Aug 12 2017 

Hooray for reopening it! Indeed even with <body style="width:200px; height:200px"> in the popup html the first displayed frame shows a 32x32px empty and useless rectangle.

Comment 6 by schenney@chromium.org, Aug 14 2017

Labels: -Pri-1 PaintTeamTriaged-20170814 BugSource-User Pri-2
Owner: schenney@chromium.org
Status: Assigned (was: Available)
This is not a P1 because the content does resize and functionality is not affected.

I'll look into what is happening, but my guess is that it will be hard to fix.

Comment 7 by schenney@chromium.org, Aug 14 2017

Components: -Blink>Compositing Internals>Compositing
Owner: ----
Status: Untriaged (was: Assigned)
This is in cc, not Blink. Un-assigning.

Comment 8 by vmi...@chromium.org, Aug 17 2017

Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
schenney@ could you please clarify comment #7?  What made you think it's a CC issue?

Comment 9 by schenney@chromium.org, Aug 18 2017

Owner: vmi...@chromium.org
The change that broke it, but fixed something else, was to cc/surfaces/display.cc.
That's https://chromium.googlesource.com/chromium/src/+/e95e17121740b79c447cb93d0e1d07bbfc407a14

I'm not sure the fix should be there, but I don't know where else to start.

Back to vmiura@.

Comment 10 by robliao@chromium.org, Sep 25 

Triage: Is this still an issue?

Comment 11 by woxxom@gmail.com, Sep 25 

Yes, nothing has changed.

Comment 12 by mmanchala@chromium.org, Nov 22

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
**Mass UI Triage**

This issue is still reproduced on Windows 10 OS from M60 to latest canary-72.0.3618.0.Could some one from dev please take a look.

Thanks..!!
►

Sign in to add a comment