Absent dependency in Blink sometimes (race condition,
Reported by
apisa...@yandex-team.ru,
Aug 11 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36 Steps to reproduce the problem: There is exist next include chain in WebKit (in form of file (build target): third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h (//third_party/WebKit/Source/platform/loader) -> third_party/WebKit/Source/platform/network/EncodedFormData.h (//third_party/WebKit/Source/platform) -> third_party/WebKit/Source/platform/blob/BlobData.h (//third_party/WebKit/Source/platform) -> gen/storage/public/interfaces/blobs.mojom-blink.h (//storage/public/interfaces) -> gen/storage/public/interfaces/blobs.mojom-shared.h (//storage/public/interfaces) -> storage/public/interfaces/blobs.mojom-shared-internal.h (//storage/public/interfaces) -> url/mojo/url.mojom-shared-internal.h (//url/mojo:url_mojom_gurl) But there is no path between next dependencies: //third_party/WebKit/Source/platform/loader -> //third_party/WebKit/Source/platform - because it will be reverse of exist dependency //third_party/WebKit/Source/platform -> //storage/public/interfaces - this one absent for no reason And I think there are many other problems like this. So I propose to do something like this: 1) Split //third_party/WebKit/Source/platform (we need //third_party/WebKit/Source/platform/network and //third_party/WebKit/Source/platform/blob to solve this problem) 2) Add correct deps to //third_party/WebKit/Source/platform/loader, //third_party/WebKit/Source/platform and new targets So I want to know what do you think about it? I can make CL today, in worst case on Monday. What is the expected behavior? All deps are in place. What went wrong? Build have race condition and fail occasionally. Did this work before? N/A Chrome version: 60.0.3112.90 Channel: stable OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 26.0 r0
,
Aug 11 2017
Have you seen a build failure caused by this anywhere on any of the builders on https://build.chromium.org/? How often does this cause a build failure on your workstation?
,
Aug 14 2017
Builders have no such error. On my workstation, it appears first time. But there is race condition according to error, which I have, and to research of build file, that I made. I will try to find the way of reproduction, but probably there is no 100% way to do it.
,
Sep 25 2017
apisarev@yandex-team.ru: Feel free to upload a CL with the proposed fix if this is still an issue; the reviewers would be the OWNERS of the relevant directories.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21c18d015a215df8e3f5e24386b9db06c3f1ed6 commit a21c18d015a215df8e3f5e24386b9db06c3f1ed6 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Thu Oct 12 10:10:31 2017 Stop including skia headers from CrossThreadCopier.h and SharedBufer.h To stop having unnecessary dependency from BUILD.gn files in platform sub-directories to third_party/skia, stop including skia headers from following two platform headers. - WebKit/Source/platform/CrossThreadCopier.h - WebKit/Source/platform/SharedBuffer.h This allows platform/{loader,scheduler} to build without skia dependency, and makes coming BUILD.gn split changes simple. Bug: 754600 Change-Id: I16301739bebc175f5c329142f71120a59394dd03 Reviewed-on: https://chromium-review.googlesource.com/714741 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#508300} [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/CrossThreadCopier.h [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/SharedBuffer.cpp [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/SharedBuffer.h [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/loader/BUILD.gn [modify] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/third_party/WebKit/Source/platform/scheduler/BUILD.gn
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/080c70a7f837beb92ba1a6af71fd32098466656b commit 080c70a7f837beb92ba1a6af71fd32098466656b Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Fri Oct 13 10:08:05 2017 Split WebKit platform build file A race condition was found in the build of //third_party/WebKit/Source/platform/loader. To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. All of these done in this CL. Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it to submit since it needs quick rebase works to catch up HEAD. Bug: 754600 Change-Id: I5f70348fac10f270df99b658608cf23685ed937e Test: gn check out/Release && ninja -C out/Release Reviewed-on: https://chromium-review.googlesource.com/612284 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Daniel Bratell <bratell@opera.com> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> Cr-Commit-Position: refs/heads/master@{#508661} [modify] https://crrev.com/080c70a7f837beb92ba1a6af71fd32098466656b/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/080c70a7f837beb92ba1a6af71fd32098466656b/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/080c70a7f837beb92ba1a6af71fd32098466656b/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/080c70a7f837beb92ba1a6af71fd32098466656b/third_party/WebKit/Source/platform/network/BUILD.gn
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eff8bcc62b8fba8552f166b6089a22c7b4397012 commit eff8bcc62b8fba8552f166b6089a22c7b4397012 Author: Balazs Engedy <engedy@chromium.org> Date: Fri Oct 13 10:38:22 2017 Revert "Split WebKit platform build file" This reverts commit 080c70a7f837beb92ba1a6af71fd32098466656b. Reason for revert: compile failure on "Google Chrome ChromeOS" FAILED: obj/third_party/WebKit/Source/platform/network/network/MIMETypeRegistry.o ../../third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp:17:10: fatal error: 'public/platform/mime_registry.mojom-blink.h' file not found #include "public/platform/mime_registry.mojom-blink.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Split WebKit platform build file > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > All of these done in this CL. > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > to submit since it needs quick rebase works to catch up HEAD. > > Bug: 754600 > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > Test: gn check out/Release && ninja -C out/Release > Reviewed-on: https://chromium-review.googlesource.com/612284 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Daniel Bratell <bratell@opera.com> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508661} TBR=kinuko@chromium.org,toyoshim@chromium.org,bratell@opera.com,apisarev@yandex-team.ru,dglazkov@chromium.org Change-Id: Ib68af601d53cd5f0f8fae621fb9324bf3b94880f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754600 Reviewed-on: https://chromium-review.googlesource.com/718516 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#508665} [modify] https://crrev.com/eff8bcc62b8fba8552f166b6089a22c7b4397012/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/f08a9a2c6fb656227b17a6e98713d6a19546d6b2/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/eff8bcc62b8fba8552f166b6089a22c7b4397012/third_party/WebKit/Source/platform/loader/BUILD.gn [delete] https://crrev.com/f08a9a2c6fb656227b17a6e98713d6a19546d6b2/third_party/WebKit/Source/platform/network/BUILD.gn
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/997ce7ad904c0d5ad47fdb245773966ccc0436e5 commit 997ce7ad904c0d5ad47fdb245773966ccc0436e5 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Mon Oct 16 07:47:25 2017 Reland "Split WebKit platform build file" platform/network/BUILD.gn lacked mojo_bindings_blink dependency. This caused a race on compiling. This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b Original change's description: > Split WebKit platform build file > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > All of these done in this CL. > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > to submit since it needs quick rebase works to catch up HEAD. > > Bug: 754600 > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > Test: gn check out/Release && ninja -C out/Release > Reviewed-on: https://chromium-review.googlesource.com/612284 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Daniel Bratell <bratell@opera.com> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508661} TBR=engedy@chromium.org Bug: 754600 Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc Reviewed-on: https://chromium-review.googlesource.com/718243 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#508993} [modify] https://crrev.com/997ce7ad904c0d5ad47fdb245773966ccc0436e5/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/997ce7ad904c0d5ad47fdb245773966ccc0436e5/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/997ce7ad904c0d5ad47fdb245773966ccc0436e5/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/997ce7ad904c0d5ad47fdb245773966ccc0436e5/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/997ce7ad904c0d5ad47fdb245773966ccc0436e5/third_party/WebKit/public/BUILD.gn
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e9f22cdca7f2f7b0cb104396e4ce8cccd2ed2f commit 95e9f22cdca7f2f7b0cb104396e4ce8cccd2ed2f Author: Balazs Engedy <engedy@chromium.org> Date: Mon Oct 16 08:55:47 2017 Revert "Reland "Split WebKit platform build file"" This reverts commit 997ce7ad904c0d5ad47fdb245773966ccc0436e5. Reason for revert: There still seems to be a race condition causing non-deterministic compile errors: FAILED: obj/third_party/WebKit/Source/platform/loader/test_support/FetchTestingPlatformSupport.obj ../../third_party/WebKit/Source\platform/blob/BlobData.h(42): fatal error C1083: Cannot open include file: 'storage/public/interfaces/blobs.mojom-blink.h': No such file or directory Original change's description: > Reland "Split WebKit platform build file" > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > This caused a race on compiling. > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > Original change's description: > > Split WebKit platform build file > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > All of these done in this CL. > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > to submit since it needs quick rebase works to catch up HEAD. > > > > Bug: 754600 > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > Test: gn check out/Release && ninja -C out/Release > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508661} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > Reviewed-on: https://chromium-review.googlesource.com/718243 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508993} TBR=kinuko@chromium.org,toyoshim@chromium.org,engedy@chromium.org,bratell@opera.com,apisarev@yandex-team.ru,dglazkov@chromium.org Change-Id: I439724cb5a6b98232b8af3b0f21af7960643023a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754600 Reviewed-on: https://chromium-review.googlesource.com/720876 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#508997} [modify] https://crrev.com/95e9f22cdca7f2f7b0cb104396e4ce8cccd2ed2f/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/aadc264de1e60a3490b61f2df6193b64dd164ac9/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/95e9f22cdca7f2f7b0cb104396e4ce8cccd2ed2f/third_party/WebKit/Source/platform/loader/BUILD.gn [delete] https://crrev.com/aadc264de1e60a3490b61f2df6193b64dd164ac9/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/95e9f22cdca7f2f7b0cb104396e4ce8cccd2ed2f/third_party/WebKit/public/BUILD.gn
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cf9f36ebac1df1fafc6a9ecf15a452177300382 commit 1cf9f36ebac1df1fafc6a9ecf15a452177300382 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Oct 17 11:15:31 2017 Reland "Reland "Split WebKit platform build file"" test_support of platform/loader and platform/network should depends on //storage/public/interfaces:interfaces_blink__generator because it indirectly includes generated mojo interface headers. This is the root cause of the original issue, and it seems BUILD file splitting makes it happens more easily. This is a reland of 997ce7ad904c0d5ad47fdb245773966ccc0436e5 Original change's description: > Reland "Split WebKit platform build file" > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > This caused a race on compiling. > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > Original change's description: > > Split WebKit platform build file > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > All of these done in this CL. > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > to submit since it needs quick rebase works to catch up HEAD. > > > > Bug: 754600 > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > Test: gn check out/Release && ninja -C out/Release > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508661} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > Reviewed-on: https://chromium-review.googlesource.com/718243 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508993} TBR=engedy@chromium.org Bug: 754600 Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd Reviewed-on: https://chromium-review.googlesource.com/720542 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509359} [modify] https://crrev.com/1cf9f36ebac1df1fafc6a9ecf15a452177300382/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/1cf9f36ebac1df1fafc6a9ecf15a452177300382/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/1cf9f36ebac1df1fafc6a9ecf15a452177300382/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/1cf9f36ebac1df1fafc6a9ecf15a452177300382/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/1cf9f36ebac1df1fafc6a9ecf15a452177300382/third_party/WebKit/public/BUILD.gn
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebd4f5e0d85b014a350dcf713875ad53ad5f1c8a commit ebd4f5e0d85b014a350dcf713875ad53ad5f1c8a Author: John Abd-El-Malek <jam@chromium.org> Date: Tue Oct 17 16:48:09 2017 Revert "Reland "Reland "Split WebKit platform build file""" This reverts commit 1cf9f36ebac1df1fafc6a9ecf15a452177300382. Reason for revert: this is causing build flake, i.e. see https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F530538%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout The problem is that depending on "//third_party/WebKit/Source/platform/blob:generator doesn't generate the headers for url.mojom-blink.h Original change's description: > Reland "Reland "Split WebKit platform build file"" > > test_support of platform/loader and platform/network should > depends on //storage/public/interfaces:interfaces_blink__generator > because it indirectly includes generated mojo interface headers. > > This is the root cause of the original issue, and it seems > BUILD file splitting makes it happens more easily. > > This is a reland of 997ce7ad904c0d5ad47fdb245773966ccc0436e5 > Original change's description: > > Reland "Split WebKit platform build file" > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > This caused a race on compiling. > > > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > > Original change's description: > > > Split WebKit platform build file > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > All of these done in this CL. > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > Bug: 754600 > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > Test: gn check out/Release && ninja -C out/Release > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508993} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > Reviewed-on: https://chromium-review.googlesource.com/720542 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509359} TBR=kinuko@chromium.org,toyoshim@chromium.org,engedy@chromium.org,bratell@opera.com,eae@chromium.org,apisarev@yandex-team.ru,dglazkov@chromium.org Change-Id: I4f00547b80b6ec33d3efb756460073149c12f2c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754600 Reviewed-on: https://chromium-review.googlesource.com/723739 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#509413} [modify] https://crrev.com/ebd4f5e0d85b014a350dcf713875ad53ad5f1c8a/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/11e6ab3567786cd80f5c1a2b0086ec6a1bfa1fff/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/ebd4f5e0d85b014a350dcf713875ad53ad5f1c8a/third_party/WebKit/Source/platform/loader/BUILD.gn [delete] https://crrev.com/11e6ab3567786cd80f5c1a2b0086ec6a1bfa1fff/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/ebd4f5e0d85b014a350dcf713875ad53ad5f1c8a/third_party/WebKit/public/BUILD.gn
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c commit ab4da6c885e4101a3b99642be2aa85b9c69b8c8c Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Oct 18 12:07:06 2017 Reland "Reland "Reland "Split WebKit platform build file""" blobs.mojom-blink.h internally depends on url.mojom-blink.h. So, we should have //url/mojo:url_mojom_gurl_blink__generator dependency in blob:generator target on which other test_support source_set depends. confirmed that generated ninja files, i.e. ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp This is a reland of 1cf9f36ebac1df1fafc6a9ecf15a452177300382 Original change's description: > Reland "Reland "Split WebKit platform build file"" > > test_support of platform/loader and platform/network should > depends on //storage/public/interfaces:interfaces_blink__generator > because it indirectly includes generated mojo interface headers. > > This is the root cause of the original issue, and it seems > BUILD file splitting makes it happens more easily. > > This is a reland of 997ce7ad904c0d5ad47fdb245773966ccc0436e5 > Original change's description: > > Reland "Split WebKit platform build file" > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > This caused a race on compiling. > > > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > > Original change's description: > > > Split WebKit platform build file > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > All of these done in this CL. > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > Bug: 754600 > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > Test: gn check out/Release && ninja -C out/Release > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508993} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > Reviewed-on: https://chromium-review.googlesource.com/720542 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509359} TBR=jam@chromium.org Bug: 754600 Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e Reviewed-on: https://chromium-review.googlesource.com/725139 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509749} [modify] https://crrev.com/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/ab4da6c885e4101a3b99642be2aa85b9c69b8c8c/third_party/WebKit/public/BUILD.gn
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d11ebb7af82b7b57bf2232037d4c6d9b2b78c261 commit d11ebb7af82b7b57bf2232037d4c6d9b2b78c261 Author: ccameron chromium <ccameron@chromium.org> Date: Wed Oct 18 18:12:50 2017 Revert "Reland "Reland "Reland "Split WebKit platform build file"""" This reverts commit ab4da6c885e4101a3b99642be2aa85b9c69b8c8c. Reason for revert: Suspected of causing flaky compile failures on main builder, see crbug.com/776008. Also see previous instance crbug.com/750883. Original change's description: > Reland "Reland "Reland "Split WebKit platform build file""" > > blobs.mojom-blink.h internally depends on url.mojom-blink.h. > So, we should have //url/mojo:url_mojom_gurl_blink__generator > dependency in blob:generator target on which other test_support > source_set depends. > > confirmed that generated ninja files, i.e. > ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja > has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp > > This is a reland of 1cf9f36ebac1df1fafc6a9ecf15a452177300382 > Original change's description: > > Reland "Reland "Split WebKit platform build file"" > > > > test_support of platform/loader and platform/network should > > depends on //storage/public/interfaces:interfaces_blink__generator > > because it indirectly includes generated mojo interface headers. > > > > This is the root cause of the original issue, and it seems > > BUILD file splitting makes it happens more easily. > > > > This is a reland of 997ce7ad904c0d5ad47fdb245773966ccc0436e5 > > Original change's description: > > > Reland "Split WebKit platform build file" > > > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > > This caused a race on compiling. > > > > > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > > > Original change's description: > > > > Split WebKit platform build file > > > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > > All of these done in this CL. > > > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > > > Bug: 754600 > > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > > Test: gn check out/Release && ninja -C out/Release > > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > > > TBR=engedy@chromium.org > > > > > > Bug: 754600 > > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508993} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > > Reviewed-on: https://chromium-review.googlesource.com/720542 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#509359} > > TBR=jam@chromium.org > > Bug: 754600 > Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e > Reviewed-on: https://chromium-review.googlesource.com/725139 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509749} TBR=kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,engedy@chromium.org,bratell@opera.com,eae@chromium.org,apisarev@yandex-team.ru,dglazkov@chromium.org Change-Id: Ia12728c6b84a948cd75dc6f9b8c152a3589775d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754600 Reviewed-on: https://chromium-review.googlesource.com/726459 Reviewed-by: ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#509814} [modify] https://crrev.com/d11ebb7af82b7b57bf2232037d4c6d9b2b78c261/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/65e9bff284471585eb4df740d6f8803718a324e6/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/d11ebb7af82b7b57bf2232037d4c6d9b2b78c261/third_party/WebKit/Source/platform/loader/BUILD.gn [delete] https://crrev.com/65e9bff284471585eb4df740d6f8803718a324e6/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/d11ebb7af82b7b57bf2232037d4c6d9b2b78c261/third_party/WebKit/public/BUILD.gn
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5db82f143432d72549a2f5d91135c4c8edb8714 commit f5db82f143432d72549a2f5d91135c4c8edb8714 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Thu Oct 19 21:54:02 2017 Reland "Reland "Reland "Reland "Split WebKit platform build file"""" Dependency from platform/loader to url/mojo/url.mojom-shared-internal.h was still missed in the previous change. This is a reland of ab4da6c885e4101a3b99642be2aa85b9c69b8c8c Original change's description: > Reland "Reland "Reland "Split WebKit platform build file""" > > blobs.mojom-blink.h internally depends on url.mojom-blink.h. > So, we should have //url/mojo:url_mojom_gurl_blink__generator > dependency in blob:generator target on which other test_support > source_set depends. > > confirmed that generated ninja files, i.e. > ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja > has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp > > This is a reland of 1cf9f36ebac1df1fafc6a9ecf15a452177300382 > Original change's description: > > Reland "Reland "Split WebKit platform build file"" > > > > test_support of platform/loader and platform/network should > > depends on //storage/public/interfaces:interfaces_blink__generator > > because it indirectly includes generated mojo interface headers. > > > > This is the root cause of the original issue, and it seems > > BUILD file splitting makes it happens more easily. > > > > This is a reland of 997ce7ad904c0d5ad47fdb245773966ccc0436e5 > > Original change's description: > > > Reland "Split WebKit platform build file" > > > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > > This caused a race on compiling. > > > > > > This is a reland of 080c70a7f837beb92ba1a6af71fd32098466656b > > > Original change's description: > > > > Split WebKit platform build file > > > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > > All of these done in this CL. > > > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > > > Bug: 754600 > > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > > Test: gn check out/Release && ninja -C out/Release > > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > > > TBR=engedy@chromium.org > > > > > > Bug: 754600 > > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508993} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > > Reviewed-on: https://chromium-review.googlesource.com/720542 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#509359} > > TBR=jam@chromium.org > > Bug: 754600 > Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e > Reviewed-on: https://chromium-review.googlesource.com/725139 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509749} TBR=ccameron@chromium.org Bug: 754600 Change-Id: Id13528a0181a589ad85dc67ea2c57fa384c68b36 Reviewed-on: https://chromium-review.googlesource.com/727443 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#510223} [modify] https://crrev.com/f5db82f143432d72549a2f5d91135c4c8edb8714/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/f5db82f143432d72549a2f5d91135c4c8edb8714/third_party/WebKit/Source/platform/blob/BUILD.gn [modify] https://crrev.com/f5db82f143432d72549a2f5d91135c4c8edb8714/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/f5db82f143432d72549a2f5d91135c4c8edb8714/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/f5db82f143432d72549a2f5d91135c4c8edb8714/third_party/WebKit/public/BUILD.gn
,
Oct 20 2017
One another followup CL will come, but the problem should be fixed by the last change (if it won't be reverted...)
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54 commit b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Oct 24 09:58:48 2017 http_names should be generated in the same level path Now, http_names.json exists in platform/network directory, but generated header is placed in platform/. To avoid unnecessary confusion, let's generate the header in the same level path, platform/network so that developers can find the original json file easily by following the include header path. Bug: 754600 Change-Id: If87393435dea22ca5a7202c0b037c4fcd3bb6204 Reviewed-on: https://chromium-review.googlesource.com/718298 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#511073} [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/CoreInitializer.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/loader/AllowedByNosniff.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/loader/HttpEquiv.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/workers/InstalledScriptsManager.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/cachestorage/Cache.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/eventsource/EventSource.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/MultipartParser.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/MultipartParserTest.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/Request.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/modules/fetch/Response.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/exported/WebCORS.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/exported/WebCORSPreflightResultCache.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/ClientHintsPreferences.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/ClientHintsPreferencesTest.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/FetchUtils.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/network/BUILD.gn [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/network/ContentSecurityPolicyResponseHeaders.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/network/HTTPParsers.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/b5bd67a6d1f77ba662eb7f9ed42de0a631fc5b54/third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp |
||||
►
Sign in to add a comment |
||||
Comment 1 by manoranj...@chromium.org
, Aug 11 2017