Issue metadata
Sign in to add a comment
|
PipelineIntegrationTest.MediaSource_ConfigChange_EncryptedThenClear_MP4_CENC failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) |
||||||||||||||||||
Issue descriptionmedia_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) Builders failed on: - Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 First failing build https://uberchromegw.corp.google.com/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29019
,
Aug 11 2017
sauspect https://chromium-review.googlesource.com/c/607176, attempt to revert.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42c3d2a9e44b422c0ef4c9516a4011aca229a862 commit 42c3d2a9e44b422c0ef4c9516a4011aca229a862 Author: Olga Sharonova <olka@chromium.org> Date: Fri Aug 11 08:01:15 2017 Revert "Move internal Pipeline::Stop() call to WMPI" This reverts commit 2ff16cbf883246bb6131412930538bce240125f4. Reason for revert: suspected of breaking PipelineIntegrationTest.MediaSource_ConfigChange_EncryptedThenClear_MP4_CENC on ChrOS BUG= 754596 Original change's description: > Move internal Pipeline::Stop() call to WMPI > > Currently, almost all calls to Pipeline's public interface first pass > through PipelineController. The one exception is that Pipeline calls its > own Stop() in OnError(). > > This CL moves the internal Pipeline's calls to Stop() out to WMPI. This > gives PipelineController an opportunity to adjust its internal state > appropriately. It also makes Pipeline easier to reason about, since it > doesn't change its own state. > > Bug: 695734 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ice20a4e93e0d1a2068f195ad9da15763353f8d5d > Reviewed-on: https://chromium-review.googlesource.com/607176 > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#493649} TBR=sandersd@chromium.org,tguilbert@chromium.org Change-Id: If08486601d576060b029c056841adc418de0c712 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 695734 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/612080 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#493683} [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/base/pipeline.h [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/base/pipeline_impl.cc [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/base/pipeline_impl.h [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/base/pipeline_impl_unittest.cc [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/filters/pipeline_controller.cc [modify] https://crrev.com/42c3d2a9e44b422c0ef4c9516a4011aca229a862/media/filters/pipeline_controller.h
,
Aug 11 2017
,
Aug 11 2017
Build with the revert is green: https://uberchromegw.corp.google.com/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29029 tguilbert@ could you please fix the patch and re-land?
,
Aug 11 2017
,
Aug 14 2017
Thank you for catching this!
,
Aug 14 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by olka@chromium.org
, Aug 11 2017