Improve PDF Viewer right click behavior |
||
Issue descriptionCurrently, the PDF Viewer's right click behavior will simply clear any selected text outside of form text areas, or do nothing if the right click is within the selected text. This does not take form text areas into consideration at all. To improve, it needs to consider a few more scenarios and deal with them: 1. When a form text area has focus, right clicking outside in a non-form area should remove the focus from the form text area. 2. When right clicking inside a form text area, it should gain focus.
,
Aug 31 2017
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/63b012652da22f75172895a975ea7932e63dcc81 commit 63b012652da22f75172895a975ea7932e63dcc81 Author: Lei Zhang <thestig@chromium.org> Date: Thu Aug 31 16:40:39 2017 Implement FORM_OnFocus() API. Given a point, if there is an annotation at the point, give if focus if it is not focus already. If there is no annotation at the point, then remove the focus from the focused annotation. BUG= chromium:754594 Change-Id: Iec3070472bbbfbad9d86e517f25da560f82efd4e Reviewed-on: https://pdfium-review.googlesource.com/12530 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/fpdfsdk/fpdfformfill.cpp [add] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/testing/resources/javascript/mouse_events.in [add] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/testing/resources/javascript/mouse_events.evt [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/public/fpdf_formfill.h [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/fpdfsdk/fpdfview_c_api_test.c [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/fpdfsdk/cpdfsdk_pageview.h [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/samples/pdfium_test.cc [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/testing/tools/test_runner.py [modify] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/fpdfsdk/cpdfsdk_pageview.cpp [add] https://crrev.com/63b012652da22f75172895a975ea7932e63dcc81/testing/resources/javascript/mouse_events_expected.txt
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e1ef671553e43a24c88669379af61c59b7081d commit f6e1ef671553e43a24c88669379af61c59b7081d Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Thu Aug 31 21:59:36 2017 Roll src/third_party/pdfium/ af59cf16b..47a90b894 (12 commits) https://pdfium.googlesource.com/pdfium.git/+log/af59cf16b40b..47a90b894ecc $ git log af59cf16b..47a90b894 --date=short --no-merges --format='%ad %ae %s' 2017-08-31 dsinclair More BIDI code shuffling 2017-08-31 dsinclair Move bidi code to fx_bidi 2017-08-31 rharrison Properly handle \n, \r, \r\n when inserting text 2017-08-31 thestig Prevent FPDFAvail_IsDocAvail() from infinite looping. 2017-08-31 rharrison Clean up of typing in lexer code 2017-08-31 dsinclair Add component to owners 2017-08-31 dsinclair Remove fx_basic.h 2017-08-31 rharrison Prevent duplicate parses of same data, in the same recursive descent 2017-08-31 thestig Change APIs to use FPDF_BYTESTRING for keys. 2017-08-31 thestig Implement FORM_OnFocus() API. 2017-08-31 hnakashima Fixing CBC_OnedEAN13Writer checksum. 2017-08-30 npm Use vector instead of pointer in CJBig2_Segment Created with: roll-dep src/third_party/pdfium BUG= 759224 , 754594 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I6efc74f2c62576a1fdc234c62b5bf8c644c0df65 Reviewed-on: https://chromium-review.googlesource.com/646726 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#499028} [modify] https://crrev.com/f6e1ef671553e43a24c88669379af61c59b7081d/DEPS
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32e93a5537f28e82120108ef5d0a44ed8c559548 commit 32e93a5537f28e82120108ef5d0a44ed8c559548 Author: Lei Zhang <thestig@chromium.org> Date: Fri Sep 01 01:09:28 2017 PDF: Improve right click behavior in form fields. Use FORM_OnFocus() to give form fields focus, if needed, before bringing up the context menu. BUG= 754594 Change-Id: I0ddd0202f73b04b59ba5b7fc9369f9eb38a40945 Reviewed-on: https://chromium-review.googlesource.com/644773 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#499095} [modify] https://crrev.com/32e93a5537f28e82120108ef5d0a44ed8c559548/pdf/pdfium/pdfium_engine.cc
,
Sep 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Aug 16 2017