New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754590 link

Starred by 3 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Aug 2017
Cc:
melandory@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 739343



Sign in to add a comment

Regression: Unnecessary 'Show all saved password' drop down is seen for fresh user in guest mode

Reported by sans...@etouch.net, Aug 11 2017 
Chrome Version: 62.0.3182.0 (Official Build)cc46b05b55683ecf63128f6062811093fcf2ad79-refs/heads/master@{#493619}-32/64 bit
OS: Win (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6)

Steps:
1. Launch Chrome, open Guest window and navigate to gmail.com and click on sign in
2. Enter valid email id and then click on password field and observe

Actual: Unnecessary 'Show all saved password' drop down is seen for fresh user in guest mode

Expected: 'Show all saved password' drop down should not be seen for fresh user in guest mode

This is regression issue broken in M-62, will soon update the bisect info

Good build: 62.0.3181.0
Bad build: 62.0.3182.0

Note: 'Show all saved password' drop down is seen even for fresh user with no password saved.
Actual_Password.mp4
824 KB View Download
Expected_Password.mp4
108 KB View Download

Comment 1 by jmukthavaram@chromium.org, Aug 11 2017

Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7,Mac 10.12.6 & Ubuntu 14.04 using chrome latest Canary-62.0.3182.0.
Manual bisect info:
------------------
Good build: 62.0.3181.0-Revision-493197
Bad build: 62.0.3182.0-Revision-493619

Per revision bisect info:
-------------------------
You are probably looking for a change made after 493358 (known good), but no later than 493359 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/6a6d4eafd50b6c1d770d22df230efd2ebd021214..161200ebca98c1ba716ff9d015d21aadb1ee1daf

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/161200ebca98c1ba716ff9d015d21aadb1ee1daf

vasilii@, Could you please take a look and update the thread.

As it is regressed recently on M62, marking it as Release block stable label.
Thanks..!!

Comment 2 by jmukthavaram@chromium.org, Aug 11 2017 

Note:
----
Issue also observed for the normal accounts not only fro guest account.

Thanks.

Comment 3 by vasi...@chromium.org, Aug 11 2017

Cc: melandory@chromium.org
Yes, it's a bug. For the normal profile it's expected.

Comment 4 by battre@chromium.org, Aug 16 2017

Blocking: 739343

Comment 5 by ligim...@chromium.org, Aug 21 2017 

Your bug is tagged as Release block Stable. 

M62 is branching soon and we will be taking only CRITICAL merges. Please plan accordingly.

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0578a2fd1f336b8e83aec0ed9952f0e87486d858

commit 0578a2fd1f336b8e83aec0ed9952f0e87486d858
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 28 11:58:44 2017

Don't show "Show all passwords" drop-down in Guest profile.

Bug:  754590 
Change-Id: Iafe620765a87b20339bcdd94cfb2e882a6a53548
Reviewed-on: https://chromium-review.googlesource.com/635684
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497737}
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_generation_manager_unittest.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/0578a2fd1f336b8e83aec0ed9952f0e87486d858/components/password_manager/core/browser/password_manager_unittest.cc

Comment 8 by vasi...@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment