New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754588 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary tab navigation is seen on saved Password at chrome://settings/passwords

Reported by sans...@etouch.net, Aug 11 2017

Issue description

Chrome Version: 62.0.3182.0 (Official Build)cc46b05b55683ecf63128f6062811093fcf2ad79-refs/heads/master@{#493619}-32/64 bit
OS: Win (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6)

Steps:
1. Launch Chrome, sign in to gmail.com with valid credential and click on Save button of password bubble
2. Navigate to chrome://settings/passwords and press Tab key and observe tab navigation 

Actual: Unnecessary tab focus is seen on saved Password

Expected: Tab focus should not be seen on saved Password 

This is regression issue broken in M-62, will soon update the bisect info

Good build: 62.0.3181.0
Bad build: 62.0.3182.0



 
Actual_video.mp4
1.2 MB View Download
Expected_video.mp4
186 KB View Download

Comment 1 by sans...@etouch.net, Aug 11 2017

Correction:
Good build: 62.0.3174.0
Bad build: 62.0.3175.0
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: jdoerrie@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7,Mac 10.12.6 & Ubuntu 14.04 using chrome latest Canary-62.0.3182.0.
Manual bisect info:
------------------
Good build: 62.0.3174.0-Revision-491203
Bad build: 62.0.3175.0-Revision-491592

Per revision bisect info:
-------------------------
You are probably looking for a change made after 491453 (known good), but no later than 491454 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/2876f93dd50228e650b81db527e86de127fcf6f5..394e764abad5181aeba22300061840f8344a45f4

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/394e764abad5181aeba22300061840f8344a45f4

jdoerrie@, Could you please take a look and reassign to the right owner if it is not related to your change.

Thanks..!!

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0574e3cf08af073672cdf4bcbf12da7b41e0c81

commit f0574e3cf08af073672cdf4bcbf12da7b41e0c81
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Aug 29 10:33:01 2017

Disable Hidden Passwords

This change conditionally disabled the password input element. This
depends on whether the password is visible or hidden.

Bug:  754588 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I66568e5f64f583e50b28d4fc47f99a53a74ccf3f
Reviewed-on: https://chromium-review.googlesource.com/631880
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498068}
[modify] https://crrev.com/f0574e3cf08af073672cdf4bcbf12da7b41e0c81/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/f0574e3cf08af073672cdf4bcbf12da7b41e0c81/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Assigned)
r498068 is available in Chrome 62.0.3200.0, e.g. the latest Canary on Mac. Marking this as Fixed.

Sign in to add a comment