Regression : Unable to disable "Use hardware acceleration when available" option.
Reported by
avsha...@etouch.net,
Aug 11 2017
|
||||
Issue descriptionChrome version : 62.0.3182.0 (Official Build) cc46b05b55683ecf63128f6062811093fcf2ad79-refs/heads/master@{#493619} 32/64 bit OS : Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome and navigate to https://www.google.co.in/. 2. In another tab, navigate to chrome://settings/system and disable "Use hardware acceleration when available" option. 3. Restart chrome and observe "Use hardware acceleration when available" option in 'System' section. Actual Result : Unable to disable "Use hardware acceleration when available" option. Expected Result : User should be able to disable "Use hardware acceleration when available" option. This is a regression issue broken in ‘M-62’ and will soon update other info.
,
Aug 11 2017
Using the per-revision bisect providing the bisect results, Good build:62.0.3180.0(Revision:492769). Bad build:62.0.3181.0(Revision:493197). You are probably looking for a change made after 493141 (known good), but no later than 493142 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/91a9ccccadfede02a51b53ec166d5ebb688859b7..661285b9d4dcf79b97c97581dfbe32c3954e7ec4 From the CL above, assigning the issue to the concern owner @dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Reviewed-On: https://chromium-review.googlesource.com/602668 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3182.0
,
Aug 11 2017
,
Aug 14 2017
It looks like the setting can be changed if there are no other tabs open, and it fails to change (either to on or to off) if another tab is open. E.g. step 1 above.
,
Aug 14 2017
Working hypothesis: The Launch button triggers an additional click on the toggle, reversing the current setting. If there is only one tab open the shutdown happens quickly enough that the second toggle is not registered (thrown out in transit). If there are multiple tabs open, the shutdown takes long enough for the second click toggle to get through and reverse the toggle state. Commenting out the relaunch code shows that the Launch button is generating a toggle state change.
,
Aug 16 2017
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10db7308a27aaedef35b99ca8c0dff339a8a27e7 commit 10db7308a27aaedef35b99ca8c0dff339a8a27e7 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Aug 17 22:43:41 2017 [MD settings] remove action-target on settings-toggle-buttons This CL removes the action-target method of setting tap targets for toggle-buttons. To make the settings-toggle-buttons whole row tap/clickable, the extraneous outer <div> is removed. This also includes a fix for the Launch button that appears within the toggle-button to user hardware acceleration. Bug: 734275 , 754584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia8eee97f9f0d84f1c2d8352ad46494492c2b9001 Reviewed-on: https://chromium-review.googlesource.com/608817 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#495359} [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/controls/settings_toggle_button.js [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/site_settings/pdf_documents.html [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/system_page/system_page.js [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/category_default_setting_tests.js [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/google_assistant_page_test.js [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/languages_page_tests.js [modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/settings_toggle_button_tests.js
,
Aug 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by avsha...@etouch.net
, Aug 11 20172.0 MB
2.0 MB View Download