New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754574 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

bullet points stop showing in PDF files other browsers do

Reported by mwaqasma...@gmail.com, Aug 11 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Just open my attached pdf file
2. you can check it with other browsers like ie, edge,opera and safari.
3. 

What is the expected behavior?

What went wrong?
bullet points stop showing in PDF files other browsers do

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3112.90  Channel: stable
OS Version: 10.0
Flash Version:
 
AB01 - Archiving, Disposal and Storing of Records Policy and Procedure.pdf
34.6 KB Download
Components: Internals>Plugins>PDF
Reproduced on Windows, does not happen on Linux.
Status: Available (was: Unconfirmed)
Labels: Needs-Triage-M60 Needs-Bisect
Labels: -Type-Compat Type-Bug-Regression
Yes, this did regress. Will bisect.
Looks like this is from r483453. Will track down what part of the FreeType DEPS roll caused this. It's still broken on Canary, BTW.
Cc: drott@chromium.org bunge...@chromium.org
This is the FreeType commit that triggered the behavior in this bug.

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+/75cb071b3fbfa2315c5d458fee2bb465a14568ae

Can someone work with FreeType upstream to fix this? Or tell us what PDFium is doing wrong.
Labels: -Needs-Bisect -Needs-Triage-M60
so how this will be fixed
Cc: npm@chromium.org

Comment 11 by npm@chromium.org, Aug 14 2017

That commit had already caused us problems in the past but we already rolled past the fix:  https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+/abeb28f161bc11be4fcdb8af50ab4b736d34a3e5

Maybe there are more bugs, or PDFium is doing something wrong about this specifically on Windows.
On Linux, both 60.0.3112.90 and something near current tip of tree seem fine. On Windows both of these fail to show the bullet points. We're using the same FreeType for both, so it seems unlikely that this is just FreeType. On Windows, if you try to select the bullet it does get highlighted, just nothing gets drawn.
On Windows I locally reverted just FreeType commits abeb28f161bc11be4fcdb8af50ab4b736d34a3e5 and 75cb071b3fbfa2315c5d458fee2bb465a14568ae . After doing so, the bullets do show up. So this is something introduced by these changes, but hasn't been fixed yet. Note that this may actually be affecting Linux as well, the bullets get drawn, but they appear to be drawn incorrectly (I'm currently building with these commits reverted on Linux to make sure). It isn't entirely clear why yet, however.
So on Linux reverting the above two makes no difference, though I'm not sure yet why on Windows (with the revert) the bullets look like circles but on Linux the bullets look like thin lines.
So the reason I'm getting a 'line' on Linux and a 'circle' on Windows is because the 'bullet' is encoded as the character 'l' requested to be drawn with the Wingdings. However, this PDF does not embed any of its fonts and on my Linux machine I have no Wingdings font installed so I just the the 'l'.

The original issues we had with this FreeType change were in interpreting embedded font data in the PDF. This seems like something else, perhaps something to do with dealing with the Wingdings font (which, if I recall correctly has a 'symbol' cmap, but no 'unicode' cmap).
Cc: lemzw...@gmail.com
This is an issue which seems to be a change in behavior due to the interaction between FreeType commit 75cb071b3fbfa2315c5d458fee2bb465a14568ae and the Windows Wingdings font (which, I believe, has a 'symbol' cmap but no 'unicode' cmap). I'm still tracking down exactly what this interaction entails, but it would be very insightful if anyone on FreeType had any ideas. Is it expected that this FreeType change will change behavior with respect to character maps with a Wingdings like font?

Unfortunately, many of the local PDF developers around me are currently out, determining what PDFium does in the Wingdings case isn't immediately clear. I can say that on the Skia side if there isn't a 'unicode' cmap we'll select a 'symbol' cmap if it exists as a fallback 'unicode'-like cmap (it's pua).
Taking a closer look at Wingdings, it has a "(1,0)->0" aka "(Mac, Roman)->Format 0" cmap and a "(3,0)->4" aka "(Windows, Symbol)->Format 4" cmap. Note that these two are pretty contradictory -- the Mac one puts everything at the low end (since the format only goes to 255), the Windows one puts everything at 0xf020 and up (in the private use area). Note also that the PDF itself appears to claim to have its own copy of a cmap of some sort as resource 21 (though I'm not sure what, if any code is using this).
Please discuss this on the freetype-devel mailing list.  Current git of FreeType synthesizes a missing Unicode (3,1) cmap for symbol fonts also that have a (3,0) cmap.  Maybe this behaviour should be modified, probably checking the number of glyphs that can actually be mapped to Unicode.

Regardless of this FreeType change, you must not rely on FreeType's automatic cmap selection for symbol fonts (which is intended as a backup and fallback behaviour for Joe User) – I think this is what you currently do, right?  If the font in question is a symbol font, i.e., if it provides a (3,0) cmap, select it!

In other words, the behaviour in Skia should be reversed IMHO, more or less: First check for a (3,0) cmap, then try Unicode.
Cc: caryclark@chromium.org
> Please discuss this on the freetype-devel mailing list.

This may actually be an issue which needs to be resolved between Chromium/PDFium/Skia yet; this change may just be tickling something (there were multiple places in PDFium where different bits of code may do character to glyph conversions differently, I'm not sure of the current state of the code or if all of this is cleaned up yet). On the other hand I'm not sure in the larger picture when this FreeType change kicks in. If the effect is to create bogus Unicode cmaps without us knowing they're synthesized, then I'd like to know that before blaming FreeType and not looking into the other code interactions here.

> In other words, the behaviour in Skia should be reversed IMHO, more or less: First check for a (3,0) cmap, then try Unicode.

Why? If there is a Unicode cmap we want to use it (and then we may use a (3,0) cmap since it is also a 'unicode' map). If FreeType is going to claim that it has a Unicode cmap, we expect it to be valid (one that the font wants to be used). Are you saying that we should expect Unicode cmaps produced by FreeType to be invalid? Am I missing an 'is_synthetic' bit somewhere? Currently Skia tries to use a Unicode cmap if available and will then select a (3,0) cmap if available, but there's no reason to assume that a (3,0) cmap is somehow 'better'. If an actual font had both I'd assume the (3,1) camp would be more complete anyway (I'm also not entirely sure why anyone would do that, but of course it's possible).

Comment 20 Deleted

any time frame?

Comment 22 by apodt...@gmail.com, Aug 16 2017

A font without unicode cmap would not have any active cmap. How do you even get bullets? Are you using whatever is the last cmap? This is rather fragile. 

Comment 23 by apodt...@gmail.com, Aug 16 2017

Wingdings symbols are in Unicode 7.0. It is valid to generate a Unicode map for them, although FreeType should improve it. 

Comment 24 by apodt...@gmail.com, Aug 18 2017

Alright, FreeType no longer bothers with Unicode for symbol fonts. 
http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=7653c76533dcde3d87bd7af5a2c12e8c95412c12
This is not a bug fix for this issue. Whatever is exposed here regarding charmap handling is wrong.
When this bug will be fixed?
You have to update to recent FreeType git and check the results.  It's no longer a FreeType problem.
re: comment 24 / comment 26 - Thanks for the quick fix in FreeType. We'll take care of the DEPS roll.

re: comment 25 - it's fixed when it's fixed. :) My guess is in Chrome Canary (Chrome 62) this week. We'll figure out the story with Chrome 60 and 61 after that.

Comment 28 Deleted

Comment 29 Deleted

Comment 30 by npm@chromium.org, Aug 28 2017

FreeType rolls are in progress.
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56f285b4406bffd1f43ba6ef6a8e88793b55f2ba

commit 56f285b4406bffd1f43ba6ef6a8e88793b55f2ba
Author: Ben Wagner <bungeman@chromium.org>
Date: Thu Sep 21 14:22:26 2017

Roll src/third_party/freetype/src/ f2e121ab1..39ce3ac49 (36 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f2e121ab11d1..39ce3ac499d4

$ git log f2e121ab1..39ce3ac49 --date=short --no-merges --format='%ad %ae %s'
2017-09-16 wl * Version 2.8.1 released. =========================
2017-09-15 apodtele Typos.
2017-09-15 apodtele Minor.
2017-09-14 wl Update fuzzer-bot URL.
2017-09-14 wl Formatting.
2017-09-13 mpsuzuki [sfnt] lowest gcc for vectors ( e1d0249e ) is changed to 4.7.
2017-09-13 mpsuzuki [cache] Fix a possible overflow by signed integer comparison.
2017-09-13 wl [autofit] Really fix #41334 (#52000).
2017-09-12 mpsuzuki [autofit, sfnt] Fix for `make multi'.
2017-09-11 Azzuro [build] Improve builds with different MS Visual Studio versions.
2017-09-11 wl * src/sfnt/ttkern.c (tt_face_load_kern): Reject format 2 tables.
2017-09-10 apodtele Typo.
2017-09-09 apodtele Warping CHANGES.
2017-09-09 wl [autofit] Improve communication with ftgrid.
2017-09-09 wl Officially announce end of 16bit compiler support.
2017-09-08 apodtele Warping documentation updates.
2017-09-09 mpsuzuki [base] Remove a check for resource ID in the resource fork driver.
2017-09-09 mpsuzuki ChangeLog for last commit.
2017-09-09 mpsuzuki [sfnt, truetype] Register the tags for marginal fonts.
2017-09-07 apodtele Branding fixes.
2017-09-06 apodtele s/&nbsp;/~/
2017-09-05 wl Fix multiple calls of `FT_Bitmap_Convert'.
2017-09-05 wl [bdf] Fix size and resolution handling.
2017-08-25 apodtele Swap `ALLOC_MULT' arguments (#51833).
2017-08-23 wl Typo.
2017-08-23 wl [sfnt] Fix clang compilation (#51788).
2017-08-22 wl [base] Don't zero out allocated memory twice (#51816).
2017-08-22 wl [truetype] Integer overflow.
2017-08-17 apodtele [sfnt] Avoid synthetic unicode for symbol fonts with PUA.
2017-08-16 wl * src/sfnt/pngshim.c (premultiply_data): Fix compiler warnings.
2017-08-15 behdad [sfnt] Speed up PNG image loading.
2017-08-15 wl Minor comment fix.
2017-08-13 apodtele Harmony CHANGES.
2017-08-13 wl Minor.
2017-08-11 wl [sfnt, truetype] Improve handling of missing sbits.
2017-08-11 wl CHANGES: Minor update.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

BUG= chromium:754574 

Change-Id: I33b1ec33d252cec9a39bdd301c76d4613069f610
Reviewed-on: https://chromium-review.googlesource.com/621528
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503440}
[modify] https://crrev.com/56f285b4406bffd1f43ba6ef6a8e88793b55f2ba/DEPS
[modify] https://crrev.com/56f285b4406bffd1f43ba6ef6a8e88793b55f2ba/third_party/freetype/README.chromium

Cc: hdodda@chromium.org
Labels: TE-Verified-63.0.3222.0 TE-Verified-M63
Verified the issue on windows 10 using chrome M63 #63.0.3222.0 and issue seems to be fixed.

Bullet points are seen in chrome for the give pdf file in comment #0.

Attached screenshot for reference.

Adding TE-Verified labels.

Thanks!
754574.PNG
276 KB View Download
Status: Fixed (was: Available)
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium_tests/+/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922

commit adb7b59ca1771f73b71a4d1cda4fd82a41a1b922
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Oct 04 22:02:30 2017

Update corpus expectations after FT roll

Bug:  chromium:754574   pdfium:905 
Change-Id: I1b5c88895142bd328879ab0a1c61f3414a0dfc4d
Reviewed-on: https://pdfium-review.googlesource.com/15390
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_1_8.2.4__original_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected_win.pdf.7.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_9_8.2.4__remove__Description_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_21_8.2.2__T8.4_First_remove_all2_expected.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_015_expected.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_14_8.2.4_remove_Size_all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/en_foxit_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_21_8.2.4__remove_CreationDate_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_17_8.2.2__T8.4_First_remove_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.8.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.9.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/en_diy_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_22_8.2.4__remove_Order_value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_23_8.2.2__T8.4_Last_remove_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.10.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_044_expected_win.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_23_8.2.2__T8.4_Last_remove_value_expected_mac.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_17_8.2.2__T8.4_First_remove_value_expected.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_11_8.2.2_Prev_remove_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_002_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.4.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_2_8.2.4__add_type__expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_22_8.2.4__remove_Order_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_010_expected.pdf.2.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_18_8.2.4__remove_CompressedSize__obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/other/foxittext_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.5_part2/FRC_8.5_Fo_URI_Base_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.3.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_11_8.2.2_Prev_remove_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_3_8.2.4__add_type_value_expected_win.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_17_8.2.2__T8.4_First_remove_value_expected_mac.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_23_8.2.2__T8.4_Last_remove_value_expected.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_19_8.2.4__remove_CreationDate_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_015_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_15_8.2.4_remove_Size_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.6.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_20_8.2.4__remove_CreationDate_all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_16_8.2.4__remove_CompressedSize__value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/other/bookmarkgetcolor_expected.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_006_expected.pdf.4.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_6_8.2.4__remove_FileName_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_6_8.2.4__remove_FileName_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_13_8.2.4_remove_Size_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_12_8.2.4__remove_ModDate_obj__expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_21_8.2.2__T8.4_First_remove_all2_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_3_8.2.4__add_type_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/en_contact_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/other/12_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected.pdf.7.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_v_2_length_128_AuthEvent_DocOpen__expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected_mac.pdf.6.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_12_8.2.4__remove_ModDate_obj__expected_win.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/other/foxittext_expected_mac.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_10_8.2.4__remove_ModDate_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.11.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_17_8.2.4__remove_CompressedSize__all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_23_8.2.4__remove_Order_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected_win.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_9_8.2.4__remove__Description_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_5_8.2.4__remove_FileName_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part2/FRC_56_8.2.2_C_edit_C__1_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_13_8.2.4_remove_Size_value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.7.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_4_8.2.4__remove_FileName_value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_8_8.2.4__remove__Description_all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_044_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_5_8.2.4__remove_FileName_all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_AuthEvent_EFOpen_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_20_8.2.4__remove_CreationDate_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_CFM_AESV2__EncryptMetadata_F_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected_mac.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_24_8.2.4__remove_Order_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_V_5_CFM_AESV3_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_1_8.2.4__original_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_47_8.2.2_F_edit_F_32__32_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_7_8.2.4__remove_Description_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_15_8.2.4_remove_Size_obj_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_061_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_19_8.2.4__remove_CreationDate_value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.2.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_4_8.2.4__remove_FileName_value_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_CF_EFF_StdCF_Strf_Stmf_Identity_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.12.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_003_expected.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected_mac.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_2_8.2.4__add_type__expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_18_8.2.4__remove_CompressedSize__obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_035_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.13.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_39_8.2.2_C_edit_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_EncryptMetadata_None_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_023_expected.pdf.1.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/en_fqa_expected_mac.pdf.2.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part2/FRC_58_8.2.2_Count_edit_count__2_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_48_8.2.2_F_edit_F_100__100_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_2_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_14_8.2.4_remove_Size_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_24_8.2.4__remove_Order_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.2.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_11_8.2.4__remove_ModDate_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_v_1_length_40_Filter_standard_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_10_8.2.4__remove_ModDate_value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_16_8.2.4__remove_CompressedSize__value_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.5_part2/FRC_8.5_Bl_Hide_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_23_8.2.4__remove_Order_all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_8_8.2.4__remove__Description_all_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_CF_Strf_stmf_StdCF_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/5.5_simple_font_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_059_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_7_8.2.4__remove_Description_value_expected_win.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_1_embedded_font_en_feature_expected_mac.pdf.7.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_21_8.2.4__remove_CreationDate_obj_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected_win.pdf.5.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_3.5_part1/FRC_3.5_V_4_CFM_V2__expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_11_8.2.4__remove_ModDate_all_expected_win.pdf.0.png
[add] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.2_part1/FRC_21_8.2.2__T8.4_First_remove_all2_expected_mac.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/text/en_fqa_expected.pdf.2.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_061_expected.pdf.1.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/FRC_8.2.4_part1/FRC_17_8.2.4__remove_CompressedSize__all_expected_win.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected.pdf.6.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_055_expected.pdf.3.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/third_party/tcpdf/example_053_expected.pdf.0.png
[modify] https://crrev.com/adb7b59ca1771f73b71a4d1cda4fd82a41a1b922/fx/font/font_2_embedded_font_en_size14_expected_win.pdf.6.png

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium_tests/+/ae1650f5459d720c866a8a4b74f58529f3efc4f1

commit ae1650f5459d720c866a8a4b74f58529f3efc4f1
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Oct 05 13:28:46 2017

Update Mac corpus expectations for FT roll.

This updates the Mac expectations for the FreeType c06b9cf roll.
The previous try somehow did not update the Mac expectation files
correctly.

BUG= chromium:754574 , pdfium:905 

Change-Id: I7d1bbdcf7f4f89f76f1c996975209e8acf784c98
Reviewed-on: https://pdfium-review.googlesource.com/15472
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>

[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_9_8.2.4__remove__Description_obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_21_8.2.2__T8.4_First_remove_all2_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_V_4_CFM_V2__expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_V_5_CFM_AESV3_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_10_8.2.4__remove_ModDate_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_AuthEvent_EFOpen_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_1_8.2.4__original_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_CF_EFF_StdCF_Strf_Stmf_Identity_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_17_8.2.2__T8.4_First_remove_value_expected_mac.pdf.1.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_CFM_AESV2__EncryptMetadata_F_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_11_8.2.4__remove_ModDate_all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.5_part2/FRC_8.5_Fo_URI_Base_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_13_8.2.4_remove_Size_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_24_8.2.4__remove_Order_obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_8_8.2.4__remove__Description_all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_17_8.2.4__remove_CompressedSize__all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_18_8.2.4__remove_CompressedSize__obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_22_8.2.4__remove_Order_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_12_8.2.4__remove_ModDate_obj__expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.5_part2/FRC_8.5_Bl_Hide_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_14_8.2.4_remove_Size_all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_15_8.2.4_remove_Size_obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_16_8.2.4__remove_CompressedSize__value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_3_8.2.4__add_type_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_2_8.2.4__add_type__expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_23_8.2.2__T8.4_Last_remove_value_expected_mac.pdf.1.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_EncryptMetadata_None_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_6_8.2.4__remove_FileName_obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_21_8.2.4__remove_CreationDate_obj_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_20_8.2.4__remove_CreationDate_all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_2_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_CF_Strf_stmf_StdCF_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_v_1_length_40_Filter_standard_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_21_8.2.2__T8.4_First_remove_all2_expected_mac.pdf.1.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_23_8.2.4__remove_Order_all_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_23_8.2.2__T8.4_Last_remove_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_4_8.2.4__remove_FileName_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_19_8.2.4__remove_CreationDate_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_3.5_part1/FRC_3.5_v_2_length_128_AuthEvent_DocOpen__expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.2_part1/FRC_17_8.2.2__T8.4_First_remove_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_7_8.2.4__remove_Description_value_expected_mac.pdf.0.png
[modify] https://crrev.com/ae1650f5459d720c866a8a4b74f58529f3efc4f1/fx/FRC_8.2.4_part1/FRC_5_8.2.4__remove_FileName_all_expected_mac.pdf.0.png

 Issue 773662  has been merged into this issue.

Sign in to add a comment