New issue
Advanced search Search tips

Issue 754572 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Show PIN settings as disabled by policy

Project Member Reported by tbuck...@chromium.org, Aug 11 2017

Issue description

Right now, if PIN Settings isn't enabled due to enterprise policy, we hide it in the Settings UI. Instead we should show the PIN radio button using the "disabled by policy" pattern, which involves graying it out and showing the policy icon with a tooltip.

@sammiequon could you look into this for M63?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48498fbd26536fd330d53a0621587ade92a041fe

commit 48498fbd26536fd330d53a0621587ade92a041fe
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Aug 23 23:45:08 2017

settings: Display policy indicator when PIN is disabled by policy.

Previously would just hide the Screen options section. Now the policy indicator gets shown next to the Screen options header, and the options get disabled. If PIN is also disabled some other way (feature, supervised user), the Screen options section remains hidden.

Test: manual
Bug:  754572 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9e2babc36819b5c6bd3116172782d86d0933a116
Reviewed-on: https://chromium-review.googlesource.com/629541
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496872}
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/48498fbd26536fd330d53a0621587ade92a041fe/chrome/browser/ui/webui/settings/md_settings_ui.cc

Status: Fixed (was: Assigned)

Sign in to add a comment