New issue
Advanced search Search tips

Issue 754561 link

Starred by 1 user
Status: Archived
Owner:
x...@chromium.org
Closed: Aug 2017
Cc:
weifangsun@chromium.org
skau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Printer name can not be edited for auto-configured printers

Project Member Reported by weifangsun@chromium.org, Aug 11 2017 
Related to  crbug.com/685673  -

Currently, if a user is only updating the Name of a printer in their Settings, where the printer is an auto-configured printer, an error is being thrown. If a user also updates the Manufacturer/Model values (aka. specifies a PPD), the update is successfully saved.

We should ensure for M61 that we are able to update the Printer Name for autoconfigured printers.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b4f288e52ac25410c6c0b402ecb156933ddf95b

commit 8b4f288e52ac25410c6c0b402ecb156933ddf95b
Author: xdai <xdai@chromium.org>
Date: Mon Aug 14 23:41:00 2017

[CUPS] Do not re-configure a printer if only printer name is changed.

Instead, we only update its name.

Bug:  754561 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I731985c47844a2a4d68d3b245241443226a3b9c3
Reviewed-on: https://chromium-review.googlesource.com/614065
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494249}
[modify] https://crrev.com/8b4f288e52ac25410c6c0b402ecb156933ddf95b/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/8b4f288e52ac25410c6c0b402ecb156933ddf95b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Comment 2 by x...@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)

Comment 3 by x...@chromium.org, Aug 15 2017

Labels: Merge-Request-61

Comment 4 by keta...@chromium.org, Aug 15 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a2977a333bd51609852dedf04646a1b437baca

commit f5a2977a333bd51609852dedf04646a1b437baca
Author: xdai <xdai@chromium.org>
Date: Wed Aug 16 22:42:46 2017

[Merge to M61][CUPS] Do not re-configure a printer if only printer name is changed.

Instead, we only update its name.

TBR=michaelpg@chromium.org
(cherry picked from commit 8b4f288e52ac25410c6c0b402ecb156933ddf95b)

Bug:  754561 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I731985c47844a2a4d68d3b245241443226a3b9c3
Reviewed-on: https://chromium-review.googlesource.com/614065
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494249}
Reviewed-on: https://chromium-review.googlesource.com/618101
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#610}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/f5a2977a333bd51609852dedf04646a1b437baca/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/f5a2977a333bd51609852dedf04646a1b437baca/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment