New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754560 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in v8_inspector::InjectedScript::ProtocolPromiseHandler::cleanup

Project Member Reported by ClusterFuzz, Aug 11 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6183246407925760

Fuzzer: inferno_layout_test_fuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x23c574b0
Crash State:
  v8_inspector::InjectedScript::ProtocolPromiseHandler::cleanup
  v8::internal::GlobalHandles::DispatchPendingPhantomCallbacks
  v8::internal::GlobalHandles::PostGarbageCollectionProcessing
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=493354:493368

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6183246407925760

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 11 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 11 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 11 2017

Labels: Pri-1

Comment 4 by kenrb@chromium.org, Aug 11 2017

Components: Blink>JavaScript

Comment 5 by tsepez@chromium.org, Aug 11 2017

Owner: hablich@chromium.org
Status: Assigned (was: Untriaged)
Assinging to V8 triage sheriff (seems V8 CF sheriff OOO) per rotation.
Cc: hablich@chromium.org
Owner: kozyatinskiy@chromium.org
Looks like it is related to the inspector changes in https://chromium.googlesource.com/v8/v8/+log/1264194f491d54b2344742821c5139bb887a357d..310048219a78bbd29627a99b1fa9866a11fa4f47
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/612452
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/438a845c52e89617b6fbe29f487a9336e93aa70a

commit 438a845c52e89617b6fbe29f487a9336e93aa70a
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Aug 11 18:21:57 2017

[inspector] check callback before calling on promise collected

R=dgozman@chromium.org

Bug:  chromium:754560 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3c0d5c4eebc3e8dbfa6663210046d6a86b1226b5
Reviewed-on: https://chromium-review.googlesource.com/612452
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47321}
[modify] https://crrev.com/438a845c52e89617b6fbe29f487a9336e93aa70a/src/inspector/injected-script.cc
[modify] https://crrev.com/438a845c52e89617b6fbe29f487a9336e93aa70a/test/inspector/runtime/evaluate-async-expected.txt
[modify] https://crrev.com/438a845c52e89617b6fbe29f487a9336e93aa70a/test/inspector/runtime/evaluate-async.js

Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 12 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by ClusterFuzz, Aug 13 2017

ClusterFuzz has detected this issue as fixed in range 493971:493972.

Detailed report: https://clusterfuzz.com/testcase?key=6183246407925760

Fuzzer: inferno_layout_test_fuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x23c574b0
Crash State:
  v8_inspector::InjectedScript::ProtocolPromiseHandler::cleanup
  v8::internal::GlobalHandles::DispatchPendingPhantomCallbacks
  v8::internal::GlobalHandles::PostGarbageCollectionProcessing
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=493354:493368
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=493971:493972

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6183246407925760

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Aug 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6183246407925760 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 18 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment