New issue
Advanced search Search tips

Issue 754557 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Nested position:sticky in another sticky element disappears in HiDPI display

Reported by kim...@gmail.com, Aug 11 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Steps to reproduce the problem:
1. Place position:sticky element inside another position: sticky element.
2. Resize the page to activate sticky (make scrolling context) for the parent sticky element.

What is the expected behavior?
Sticky element should display correctly.

What went wrong?
The sticky element disappears.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 60.0.3112.90  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Possible regression of https://bugs.chromium.org/p/chromium/issues/detail?id=699852
https://bugs.chromium.org/p/chromium/issues/detail?id=672710

I posted the issue before which had been merged into an existing issue, but the problem was still not fixed entirely in Chrome 59.

To summarize, this problem occurs only in Chrome, HiDPI display (in 1x pixel ratio display, it works fine) and when sticky is nested in another sticky.

The issue that had first reported a related issue ( Issue 672710 ) and had been marked as Fixed, but the demo jsbin page used for test didn't include actual nested sticky. Therefore I believe it was an incomplete fix.

Here is the demo page link: https://codepen.io/zvuc/pen/VzWdGp
Here is a screencast: https://www.youtube.com/watch?v=VInyNDTpYWw
 
Screen Shot 2017-08-11 at 12.00.59 PM.png
1.0 MB View Download
Components: UI>HighDPI Blink>CSS Blink>Layout>Subpixel
Labels: Needs-Triage-M60
Would you mind providing a sample testcase for repro?

Comment 3 by kim...@gmail.com, Aug 12 2017

I made a codepen page for test: https://codepen.io/zvuc/pen/VzWdGp
It's also in the original issue report. 
Cc: jbanavatu@chromium.org
Labels: -Type-Bug M-62 Type-Bug-Regression
Owner: flackr@chromium.org
Status: Assigned (was: Unconfirmed)
Able to repro this issue on Mac OS X 10.12.6 with HiDPI display using chrome version 60.0.3112.90.

Bisect info: 
Good build:56.0.2909.0
Bad build:56.0.2910.0

You are probably looking for a change made after 429926 (known good), but no later than 429927 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/851c6f72587756eab07e345c2212c0d45c8c10e1..77a8c51a440e0741315ff5e9e77441b86cbbc56d

From the CL above, assigning the issue to the concern owner 

flackr @ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2468283005

Thanks!
Labels: -Type-Bug-Regression Type-Bug
That is when position: sticky got enabled, so this is not a regression.
Labels: Update-Quarterly

Comment 7 by kim...@gmail.com, Sep 26 2017

I just checked this issue again in Chrome 61, and seems like the issue has been fixed. (Tested with demo pages https://codepen.io/zvuc/pen/PpWOqv https://codepen.io/zvuc/pen/VzWdGp ) Sticky headers nested inside sticky elements now display fine in macOS 10.13(High Sierra), Chrome 61, HiDPI mode.

With just one minor issue now: The sticky elements seem to not snap to nearest pixel, leaving a sub-pixel hairline just above the sticky element and the container. (See screenshot attached) Firefox doesn't have this issue.

If I should file a separate issue for the one above and let me know and I will do so. After confirming this nested sticky issue is completely fixed I think you can safely close this issue.

Thanks!
Pasted_Image_26_09_2017__12_10_PM.jpg
461 KB View Download
Labels: -Update-Quarterly
Cc: smcgruer@chromium.org
Components: -Blink>Layout>Subpixel -UI>HighDPI -Blink>CSS -Blink>Layout Internals>Compositing>Scroll
Owner: yigu@chromium.org
Yes, nested sticky position on the compositor should have been fixed by  issue 672710  but was made even less complicated in  issue 718188 .

Yi, could you look into the subpixel gap mentioned in comment #7?

Comment 10 by yigu@chromium.org, Apr 27 2018

Status: Fixed (was: Assigned)
The subpixel gap bug is duplicated with  issue 693412 . Given the original nested bug has been fixed by my patch crrev.com/2911463002, mark this one as fixed.

Sign in to add a comment