New issue
Advanced search Search tips

Issue 754549 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724628



Sign in to add a comment

dev-cpp/glog does not build with libc++

Project Member Reported by manojgupta@chromium.org, Aug 11 2017

Issue description

This package seems to be built only on a few boards e..g daisy.

glog-0.3.2: In file included from src/stl_logging_unittest.cc:34:
glog-0.3.2: ./src/glog/stl_logging.h:77:11: fatal error: 'ext/slist' file not found
glog-0.3.2: # include <ext/slist>
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/42c3fe1e2fa83ef538ed99c238f4cda59a650133

commit 42c3fe1e2fa83ef538ed99c238f4cda59a650133
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Aug 26 18:20:51 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f922830962fd328a85f43e747d363aee7aeee5c9

commit f922830962fd328a85f43e747d363aee7aeee5c9
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Aug 26 18:20:51 2017

Update glog and gflags to fix build with libc++.

Current glog version 0.3.2 fails to build with libc++ because
it uses deprecated headers <ext/slist>. Upgrade to gentoo upstream
glog package 0.3.4 to fix the build issues.

Also, pull in gflags 2.1.1 since glog requires gflags >= 2.1.

Changes from upstream:
EAPI: 6 -> 5
KEYWORDS -> *
default -> epatch "${PATCHES[@]}"

BUG= chromium:754549 
TEST=glog builds with/without libc++.

CQ-DEPEND=CL:611920, CL:*437413
Change-Id: Ie3c13bde41432460094f9b00bd87de436eb1275b
Reviewed-on: https://chromium-review.googlesource.com/611646
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/gflags/gflags-2.1.1-r1.ebuild
[add] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/gflags/files/gflags-2.1.1-libs.patch
[add] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/glog/files/glog-0.3.4-fix-build-system.patch
[modify] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/gflags/Manifest
[delete] https://crrev.com/88cc1322d0b4aebefb4344494b3933538ebb4fc6/dev-cpp/gflags/gflags-2.0.ebuild
[modify] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/glog/Manifest
[add] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/glog/files/glog-0.3.4-fix-gcc5-demangling.patch
[add] https://crrev.com/f922830962fd328a85f43e747d363aee7aeee5c9/dev-cpp/glog/glog-0.3.4-r1.ebuild
[delete] https://crrev.com/88cc1322d0b4aebefb4344494b3933538ebb4fc6/dev-cpp/glog/glog-0.3.2.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a20fcc329fb2197813d74b91d25d73e24ddfebe5

commit a20fcc329fb2197813d74b91d25d73e24ddfebe5
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Aug 26 18:20:51 2017

autotest-deps-glbench: update gflags init code.

gflags >= 2.1 requires using gflags::ParseCommandLineFlags instead of
google::ParseCommandLineFlags. Fix affected files.

CQ-DEPEND=CL:611646

BUG= chromium:754549 
TEST=autotest-deps-glbench builds.
TEST=nyan_kitty-paladin passes.
TEST=https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/paladin/builds/3615

Change-Id: I28617df32045f52da861456a5a49d4e2b92d6dde
Reviewed-on: https://chromium-review.googlesource.com/611920
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/a20fcc329fb2197813d74b91d25d73e24ddfebe5/client/deps/glbench/src/main.cc
[modify] https://crrev.com/a20fcc329fb2197813d74b91d25d73e24ddfebe5/client/deps/glbench/src/windowmanagertest.cc

Status: Verified (was: Untriaged)

Sign in to add a comment