exo Surface::SetAlpha should cause the entire surface to be damaged |
|||||||
Issue descriptionIf you use the Wayland interface to create a visible surface, then use the zcr_blending_v1::set_alpha() to adjust the alpha value of the surface, the surface is not updated correctly. However if you use wl_surface::damage() to damage the entire surface, it is updated correctly. wl_surface::damage() is supposed to be for reporting damage in a buffer. The server interface should be realizing the entire surface is damaged when only the alpha value is being changed.
,
Aug 11 2017
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1e23fd43417af085ecf8b3a14a3e8df1801db52 commit d1e23fd43417af085ecf8b3a14a3e8df1801db52 Author: Lloyd Pique <lpique@google.com> Date: Tue Aug 15 23:10:51 2017 exo: Apply full surface damage on non-buffer changes Setting certain surface values such as the plane alpha should effectively damage the entire surface. The complete set seemed to be the scale, blending mode, plane alpha, viewport rectangle, and clip rectangle. Bug: 754548 Change-Id: I4ee8a47bdfcdbb1be4ae10b43fbf140aae25311c Reviewed-on: https://chromium-review.googlesource.com/611619 Commit-Queue: Lloyd Pique <lpique@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#494595} [modify] https://crrev.com/d1e23fd43417af085ecf8b3a14a3e8df1801db52/components/exo/surface.cc [modify] https://crrev.com/d1e23fd43417af085ecf8b3a14a3e8df1801db52/components/exo/surface.h [modify] https://crrev.com/d1e23fd43417af085ecf8b3a14a3e8df1801db52/components/exo/surface_unittest.cc
,
Aug 16 2017
,
Aug 16 2017
Approving merge to M61 Chrome OS.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4704894a31b104afcbf10642879cb907c52bff1c commit 4704894a31b104afcbf10642879cb907c52bff1c Author: David Reveman <reveman@chromium.org> Date: Thu Aug 17 20:30:12 2017 exo: Apply full surface damage on non-buffer changes Setting certain surface values such as the plane alpha should effectively damage the entire surface. The complete set seemed to be the scale, blending mode, plane alpha, viewport rectangle, and clip rectangle. TBR=lpique@google.com (cherry picked from commit d1e23fd43417af085ecf8b3a14a3e8df1801db52) Bug: 754548 Change-Id: I4ee8a47bdfcdbb1be4ae10b43fbf140aae25311c Reviewed-on: https://chromium-review.googlesource.com/611619 Commit-Queue: Lloyd Pique <lpique@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494595} Reviewed-on: https://chromium-review.googlesource.com/619488 Cr-Commit-Position: refs/branch-heads/3163@{#641} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/4704894a31b104afcbf10642879cb907c52bff1c/components/exo/surface.cc [modify] https://crrev.com/4704894a31b104afcbf10642879cb907c52bff1c/components/exo/surface_unittest.cc
,
Aug 17 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lpique@chromium.org
, Aug 11 2017