New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754537 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Snap threshold for swiping launcher from shelf

Project Member Reported by minch@chromium.org, Aug 11 2017

Issue description

Components: UI>Shell>Launcher UI>Shell>Shelf

Comment 2 by minch@chromium.org, Aug 14 2017

Labels: M-61 Merge-Request-61
Status: Started (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 14 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7c223c7f934d21891c2da62b85a276fc28118d6

commit a7c223c7f934d21891c2da62b85a276fc28118d6
Author: MinChen <minch@chromium.org>
Date: Mon Aug 14 19:00:08 2017

Change snapping threshold for dragging app list from shelf in tablet mode.

Bug:  754537 
Change-Id: I6ca803519c340f2c9ee696c81123a8628609491f
Reviewed-on: https://chromium-review.googlesource.com/612595
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494118}
[modify] https://crrev.com/a7c223c7f934d21891c2da62b85a276fc28118d6/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/a7c223c7f934d21891c2da62b85a276fc28118d6/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/a7c223c7f934d21891c2da62b85a276fc28118d6/ash/shelf/shelf_layout_manager_unittest.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Aug 18 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 21 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 21 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d84c61681fccf6c740ab0612d7c107f0c266511c

commit d84c61681fccf6c740ab0612d7c107f0c266511c
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 21 21:17:26 2017

Change snapping threshold for dragging app list from shelf in tablet mode.

TBR=minch@chromium.org

(cherry picked from commit a7c223c7f934d21891c2da62b85a276fc28118d6)

Bug:  754537 
Change-Id: I6ca803519c340f2c9ee696c81123a8628609491f
Reviewed-on: https://chromium-review.googlesource.com/612595
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494118}
Reviewed-on: https://chromium-review.googlesource.com/624721
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#714}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d84c61681fccf6c740ab0612d7c107f0c266511c/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/d84c61681fccf6c740ab0612d7c107f0c266511c/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/d84c61681fccf6c740ab0612d7c107f0c266511c/ash/shelf/shelf_layout_manager_unittest.cc

Comment 9 by minch@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment