New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Enable blink_perf.owp_storage

Project Member Reported by dmu...@chromium.org, Aug 11 2017

Issue description

Hello!

Can you enable blink_perf.owp_storage on the waterfall?

This could be added to the alert for the OWP Storage sheriff.

Change that has the benchmark:
https://chromium-review.googlesource.com/c/610949
 
Cc: -martiniss@chromium.org eyaich@chromium.org
Owner: martiniss@chromium.org
Can you tell us how long does it takes to run this benchmark locally?

Comment 2 by dmu...@chromium.org, Aug 11 2017

20 seconds.
Status: Started (was: Assigned)
I'll make a CL to schedule this benchmark today.
Ping Stephen.
Owner: rnep...@chromium.org
I'm doing some work on making sure we get rid of the rest of the @disabled annotations. I can re-enable this benchmark. (Full context, I just reached out to dmurph@ about why it was disabled, so I could move it to the new format. He then sent me here). 
Status: Fixed (was: Started)
I just did a scan, didn't see any test related failures for this. The ref build is failing everywhere, but I assume this test uses new blink features that aren't in the old ref builds? 

Closing as fixed. 

Comment 8 by dmu...@chromium.org, Aug 16 2017

Ah maybe it's because some of the trace events we want aren't in the ref
build?
Cc: nedngu...@google.com
That would make sense. Ref failures do not make the runs turn red though, so I dont think its something we have to worry about. When we roll to the next ref build the issue should go away.

Adding Ned really quick to confirm that. 
Cc: simonhatch@chromium.org
Status: Started (was: Fixed)
That is correct. 

dmuprh@: which test paths do you want to monitor? 
all of them? There's only one test right now. Do I need to enumerate them? I haven't had a working result.html for a bit so I don't know any easy way to see them.
You can use https://chromeperf.appspot.com/report 
Screen Shot 2017-08-16 at 4.18.17 PM.png
141 KB View Download
There's already an entry for "ChromiumPerf/*/blink_perf.*/*" for the main Chromium Perf Sheriff rotation, so I think this should be covered.

Checking datastore, there appears to be a sheriff assigned for these tests, so I don't think you need to any setup for monitoring.
Status: Fixed (was: Started)

Sign in to add a comment