Enable blink_perf.owp_storage |
|||||||
Issue descriptionHello! Can you enable blink_perf.owp_storage on the waterfall? This could be added to the alert for the OWP Storage sheriff. Change that has the benchmark: https://chromium-review.googlesource.com/c/610949
,
Aug 11 2017
20 seconds.
,
Aug 11 2017
I'll make a CL to schedule this benchmark today.
,
Aug 15 2017
Ping Stephen.
,
Aug 15 2017
I'm doing some work on making sure we get rid of the rest of the @disabled annotations. I can re-enable this benchmark. (Full context, I just reached out to dmurph@ about why it was disabled, so I could move it to the new format. He then sent me here).
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c813e005ecd88caccace7f485a42c24f9534ed7 commit 1c813e005ecd88caccace7f485a42c24f9534ed7 Author: rnephew <rnephew@chromium.org> Date: Tue Aug 15 22:05:08 2017 [Telemetry] Schedule blink_perf.owp_storage on perf waterfall. Bug: 754534 Change-Id: I88d7e1d31401c560953c8d27624943de481af06a Reviewed-on: https://chromium-review.googlesource.com/615784 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#494567} [modify] https://crrev.com/1c813e005ecd88caccace7f485a42c24f9534ed7/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/1c813e005ecd88caccace7f485a42c24f9534ed7/testing/buildbot/chromium.perf.json [modify] https://crrev.com/1c813e005ecd88caccace7f485a42c24f9534ed7/tools/perf/benchmarks/blink_perf.py [modify] https://crrev.com/1c813e005ecd88caccace7f485a42c24f9534ed7/tools/perf/core/benchmark_sharding_map.json [modify] https://crrev.com/1c813e005ecd88caccace7f485a42c24f9534ed7/tools/perf/core/desktop_benchmark_avg_times.json
,
Aug 16 2017
I just did a scan, didn't see any test related failures for this. The ref build is failing everywhere, but I assume this test uses new blink features that aren't in the old ref builds? Closing as fixed.
,
Aug 16 2017
Ah maybe it's because some of the trace events we want aren't in the ref build?
,
Aug 16 2017
That would make sense. Ref failures do not make the runs turn red though, so I dont think its something we have to worry about. When we roll to the next ref build the issue should go away. Adding Ned really quick to confirm that.
,
Aug 16 2017
That is correct. dmuprh@: which test paths do you want to monitor?
,
Aug 16 2017
all of them? There's only one test right now. Do I need to enumerate them? I haven't had a working result.html for a bit so I don't know any easy way to see them.
,
Aug 16 2017
You can use https://chromeperf.appspot.com/report
,
Aug 17 2017
There's already an entry for "ChromiumPerf/*/blink_perf.*/*" for the main Chromium Perf Sheriff rotation, so I think this should be covered. Checking datastore, there appears to be a sheriff assigned for these tests, so I don't think you need to any setup for monitoring.
,
Aug 17 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nedngu...@google.com
, Aug 11 2017Owner: martiniss@chromium.org