Do we have specs? We can try to squeeze this in with the rest of the work scoped for M62, but it may slip to M63.

Will the changes from this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=737743#c9
be implemented in time for M62? Because if that's the case, we won't have to change anything except removing the card and adding a div line below (like we did for History and Downloads info) just for the Bookmarks section. All other sign-in instances lgtm.

We are planning to start experimenting with the signin promos in 62 (Zine might slip to 62, but bookmarks will definitely be in 62).

Won't the current styling of the sign-in promos (both old-version and new-version) look a little odd next to the Modern bookmark manager view? I assumed we'd want to make some corresponding visual updates to the styling of the promo to match the Modern style as well.

Also worth noting: the promo is a card based on feedback from the privacy team and a corresponding discussion we had with them at UI review. In short, the privacy team felt that the "X" in the top-right corner of the promo wasn't clearly scoped to the promo when it wasn't a card, so it was non-obvious how to dismiss it. Making it a card is supposed to clarify that the "X" applies to the promo, so that users know how to dismiss it. If we want to move back from a card to a full-bleed promo, we'll need to clear it with privacy.

Apologies, should have added a mock. This is what I was thinking for Bookmarks (with the current mocks on the left and the suggested mock for Chrome Home in M62 on the right).

(Will add mocks for Zine on the other bug here: https://bugs.chromium.org/p/chromium/issues/detail?id=754529)

Sorry added the wrong screenshot: correct one attached here:

Deleted: Screen Shot 2017-08-22 at 14.10.42.png 158 KB

	Screen Shot 2017-08-22 at 14.10.42.png 158 KB View Download

Thanks Hannah! Got it, thanks for the mocks.

We will need to run these past privacy to make sure they're okay with them. As I mentioned above, the decision to make the promo a card was explicitly to satisfy concerns from the privacy team that the "X" wasn't clearly enough scoped to the promo.

Kingston, since this is really part of the Modern rollout, do you want to start that thread?

I'm also happy to start it if you would prefer, since I have more context on the privacy conversations from before.

Kingston's out of office, so it'd probably be best if you could initiate that discussion.

Started a thread with the privacy team, cc'ing you all.

Won't the current styling of the sign-in promos (both old-version and new-version) look a little odd next to the Modern bookmark manager view? I assumed we'd want to make some corresponding visual updates to the styling of the promo to match the Modern style as well.

> I meant we should update the old-version of the sign-in promos to the modern spec but we can punt the new-version if we don't have time.

Got it. Yeah, I agree that the old style promo (which will definitely still be around in 62) may look weird next to the modern style as well. Hannah - could you create a mock of what that would look like? Here's a screenshot of the current promo on 60 stable: https://screenshot.googleplex.com/HS6yvAbCYRw.png

So just to confirm the new sign-in promo from 737743 will launch in M62 as a stable experiment and the ask is for tweaks to the old sign-in promo for non experiment stable folks that will see the new bookmarks updates?

Attached a mock of what that would look like if we used the same styling as History info...

Deleted: old with modern.png 107 KB

	old with modern.png 107 KB View Download

@Hannah - exactly. It's unclear whether we'll even ever reach 100% for the new bookmark promo in 62 (that might come in 63), so we definitely need to support both versions of the promo in the meantime.

Thanks. Yes, I was suggesting that if we are short of time (which we sort of are), we drop new bookmark promo styling in 62 and get it in for 63. We don't plan on experimenting with the new bookmark promo with the new visual style anyway.

Kingston

> We don't plan on experimenting with the new bookmark promo with the new visual style anyway.

Not sure I understand. Our plan *is* to experiment with the new signin promo ("Continue as...") style in the bookmark manager in 62. I think we need to update the promo accordingly.

Hannah, can you post the updated promo styling (with the gray background) to this bug and assign it to whoever is working on the Modern migration for bookmarks?

Oh wait - I apologize. I was getting this mixed up with the Zine promos. Yes, visual style for bookmarks is an unconditional rollout so yes, we will need visual style updates for both.

For posterity: updating the bug with latest from a separate email thread where we resolved to launch with the attached design. Final copy and content to be determined by the sign in team. Thanks!

Deleted: Screen Shot 2017-08-24 at 14.29.20 (1).png 169 KB

	Screen Shot 2017-08-24 at 14.29.20 (1).png 169 KB View Download

attaching the latest mocks for the old promo with the new modern look and feel.

@Becky/Theresa, is this something you could look at quickly for M-62?

attaching the correct image for #19

Deleted: Screen Shot 2017-08-29 at 08.51.02.png 138 KB

	Screen Shot 2017-08-29 at 08.51.02.png 138 KB View Download

Is there a formal spec we can pull info about the background (e.g. corner radius, color), etc. from?

Just to add some extra clarification and context, there are two versions of the signin promo in bookmarks:

(1) Existing/"old" version, which needs to be updated per the mock in c#22
(2) New "Continue as" version (which actually has two different versions depending on whether there's a Google Account on the device), which needs to be updated per the mocks in c#18

We're planning to experiment with the new version of the promo in 62, and may want to roll it out to 100%. So it would be great if we could have both versions checked in.

I'll follow the styles for suggestion card signin promo in NTP. If there is any updates, please let me know!!

Screenshots of changes attached. This changes also change the description color from black 87 to black 54 of signin promo in recent tabs. Please take a look!

Deleted: bookmark_signin_promo_new.png 82.1 KB

	bookmark_signin_promo_new.png 82.1 KB View Download

Deleted: bookmark_signin_promo_old.png 75.7 KB

	bookmark_signin_promo_old.png 75.7 KB View Download

Deleted: recent_tabs_signin_promo.png 76.2 KB

	recent_tabs_signin_promo.png 76.2 KB View Download

lgtm! 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9893814e0864f7f14115148ff2e6672e2d89fa21

commit 9893814e0864f7f14115148ff2e6672e2d89fa21
Author: Becky Zhou <huayinz@chromium.org>
Date: Wed Aug 30 00:48:07 2017

[Chrome Home] Sign-in promo visiual refresh in Bookmarks

Bug:  754531 
Change-Id: Icf0c9ea980640bc00c7f99a704cddfa8b14dbd81
Reviewed-on: https://chromium-review.googlesource.com/642486
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498315}
[delete] https://crrev.com/5d3a5ed3f7db37fbe584f6cca9410a6df182eb62/chrome/android/java/res/drawable-hdpi/bookmarks_signin_promo_card.9.png
[delete] https://crrev.com/5d3a5ed3f7db37fbe584f6cca9410a6df182eb62/chrome/android/java/res/drawable-mdpi/bookmarks_signin_promo_card.9.png
[delete] https://crrev.com/5d3a5ed3f7db37fbe584f6cca9410a6df182eb62/chrome/android/java/res/drawable-xhdpi/bookmarks_signin_promo_card.9.png
[delete] https://crrev.com/5d3a5ed3f7db37fbe584f6cca9410a6df182eb62/chrome/android/java/res/drawable-xxhdpi/bookmarks_signin_promo_card.9.png
[delete] https://crrev.com/5d3a5ed3f7db37fbe584f6cca9410a6df182eb62/chrome/android/java/res/drawable-xxxhdpi/bookmarks_signin_promo_card.9.png
[rename] https://crrev.com/9893814e0864f7f14115148ff2e6672e2d89fa21/chrome/android/java/res/drawable/content_card_modern_background.xml
[modify] https://crrev.com/9893814e0864f7f14115148ff2e6672e2d89fa21/chrome/android/java/res/layout/signin_and_sync_view.xml
[modify] https://crrev.com/9893814e0864f7f14115148ff2e6672e2d89fa21/chrome/android/java/res/layout/signin_promo_view_bookmarks.xml
[modify] https://crrev.com/9893814e0864f7f14115148ff2e6672e2d89fa21/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/9893814e0864f7f14115148ff2e6672e2d89fa21/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java

Looks great, thanks so much for the quick turnaround!

The description color in recent tabs feels a little faint to me. Is that just the standard description color we're moving to?

It seems that there is a plan moving recent tabs to modern style soon? Correct me if I'm wrong @hannahs.

https://docs.google.com/presentation/d/1tLpPinM7AonZaY1FWMx0sCc8bP0hVJzqeqSGBnojCe4/edit#slide=id.g22e0dc7a2d_0_251

:o yes, we'll need to re-do that surface as well. Just to confirm, is recent tabs a native UI or do we need to do conversion work?

Recent tabs is a native page, using Android Views. It is a one-off implementation from the other "list ui's".

Since items in recent tabs are not selectable, it probably makes sense to make a lower-level list set of widgets that the current SelectableList* widgets rely upon. This would allow recent tabs to share code (the base list widgets) with history/downloads/bookmarks.

Ping on my question in #29 (is the color for the description text supposed to be that light? It feels very light on an already gray background).

Also, what is the plan for moving recent tabs to modern? Is there a tracking bug filed? Is that happening in 63?

I think the text is the same color in all of the screenshots Becky provided, but the contrast is lower on recent tabs because the background is a bit darker. Chris/Hannah - should we make the text on recent tabs darker for now or does it look okay?

We will move recent tabs to modern, but the milestone is TBD. We have quite a bit of work for M63, so we'll have to evaluate eng cost after we have redlines. I don't think we have a tracking bug yet.

To get an idea of what we're planning, Hannah has a slide for recents in the Chrome Modern deck: https://docs.google.com/presentation/d/1tLpPinM7AonZaY1FWMx0sCc8bP0hVJzqeqSGBnojCe4/edit#slide=id.g22e0dc7a2d_0_251

Thanks Theresa. Hannah/Kingston - Whenever we're getting around to finalizing mocks/redlines for modernizing recent tabs, let's be sure to include the signin promos early on this time (depending on the milestone, may only have to worry about "Continue as"-style promos, as the old ones may be turned off by then).

Chris/Hannah - please comment on the text color for the signin promo in recent tabs. The contrast feels too low to my eyes.

Re-assigning to Hannah to answer question about recent tabs text color contrast.

Friendly ping for Hannah

Hannah was OOO this week, so we may have to wait until she catches up on her backlog.

Hey guys, if the text is using 54% black it should be dark enough (and we'll be updating recents soon to have a white background so this will be temporary). Thanks!

Alright, marking as Fixed