The new sign-in promo is scheduled for M63 now, right? For the existing sign-in promo: yes, we're already tracking that as  issue 754186 .

We're optimistically targeting M62, but it may slip to 63. We will keep you posted on our rollout plans, but either way we'll need both versions of the designs.

@Hannah/Amy, do you know which one of you would be taking on the new modernized sign-in promo designs?

I've done some preliminary explorations, happy to continue when it's time to update them. https://docs.google.com/presentation/d/17a2NJQaWYbjKdbOOFW8lSwwGpum2MFrZMjsDZMkOSIU/edit?ts=59781ba0#slide=id.g241fc6c4c0_16_30

We are planning to experiment with Chrome Home in the modern design in M62, so isn't now the time to update them?

Yep, now is definitely the time :) To clarify requirements:

- We need mocks for both the existing M59/60 sign-in promos (i.e. text-based, not "Continue as..." style) as well as the new sign-in promos. Here's a screenshot of what the existing promo looks like, to be clear: https://screenshot.googleplex.com/VrN1BmN951f.png
- We need these mocks for both Zine (what this bug is tracking) and the bookmark manager ( Issue 754531 )
--> In total, we need four sets of mocks (existing & new promo, Zine & bookmark manager)

Also, I don't think we need these mocks for Settings (unless Settings is planning to move to Modern in 62 as well)?

Hope that helps clarify! Let me know if anything is still unclear, Amy.

No - settings is staying the same.

Hey all, I spoke with Chris and we think the best solution here for Zine (other mocks are in a separate thread) within our time constraints is to just replace the card with the grey background (mock attached). Please let me know if this makes sense and I will attach redlines! Thanks!

Deleted: Screen Shot 2017-08-24 at 15.37.52.png 327 KB

	Screen Shot 2017-08-24 at 15.37.52.png 327 KB View Download

This looks okay to me. I'll let Kingston comment from the Chrome Home/Modern side of things.

FYI - we should get new mocks with the actual promo strings (which I believe are in the mocks for the launch bug)

Spoke with elias & kingston and updated the copy for the promo to be accurate. please use this mock as the latest!

apologies attached the wrong image

Deleted: Screen Shot 2017-08-29 at 08.40.39.png 754 KB

	Screen Shot 2017-08-29 at 08.40.39.png 754 KB View Download

+Rachel as FYI

Discussed with Hannah and Kingston offline. The finalized mocks are in c#15.

We have landed all the new signin promos in M62 except for Zine. The CL is in review, and we are hoping to land it before branch. So ideally, we could do the visual translation and get the Modern-ized style of the new signin promo for Zine in M62 as well (see mocks in c#15).

However, if that's not feasible from an eng perspective before branch, we can always just make sure our Finch experiments are mutually exclusive (since we're not planning to roll out the Chrome Home Modern experiment in 62 to 100% anyways). In other words, we can force users with the Chrome Home Modern experiment to see the old version of the signin promo (which is already implemented, mock on the far left above).

Kingston is going to follow up on these questions to figure out what the plan is.

Thanks Eli, this LGTM. Did you folks go through a UI Review? 

//We have landed all the new signin promos in M62 except for Zine. The CL is in review, and we are hoping to land it before branch. So ideally, we could do the visual translation and get the Modern-ized style of the new signin promo for Zine in M62 as well (see mocks in c#15).

Just clarifying - does this mean you'd like us to loop in the Zine engineers to see if they can implement this in time for BP on Thursday? :)

Yes, we went through UI review for the new signin promos (we have our own launch bug too, Issue 737742. We're waiting on UI approval, but we've already gotten approval for the iOS versions of the same promos).

> Just clarifying - does this mean you'd like us to loop in the Zine engineers to see if they can implement this in time for BP on Thursday? :)

That was the hope :) Understood obviously if that's not possible at this point. Like I mentioned above, it just means we'll have some extra complexity on the Finch side to make sure that our experiments are mutually exclusive (i.e. that nobody in our experiment group in 62 is also in the Chrome Home experiment group).

Let me know if you want to sync in person. I'm WF Paris right now, so I could hop on a VC sometime today.

FYI, the new-style Zine signin promo just landed (https://chromium-review.googlesource.com/c/chromium/src/+/623753), so if we can't make the updates on the Zine side to Modern-ize it before branch, we'll have to make sure our Finch experiments are non-overlapping.

OK, good to know. Bernhard and I had a look at this today, and it looks like this *may* not be crazy to implement. That would depend on whether Nicolas or Michael has time today or tomorrow to put together a CL.

Michael & Nicolas - it seems like the only change that would need to happen her to bring this into modern would be to change the background. Bernhard and I are not entirely sure how complex that would be, but it seems like it could be doable. Would you mind taking a look? New mocks are in Comment 15, if you update Canary today you can see what's already built. Please feel free to ping me to clarify.

Nicolas has agreed to change the background and spacing :-)

Amazing, thanks everyone for such a quick turnaround!

Looking at the mocks in #15 vs. what's implemented in today's Canary (https://screenshot.googleplex.com/DBb5tGzctr2.png vs. https://screenshot.googleplex.com/MzUM4PgysO4.png), it does seem like the only things that need changing are the background and spacing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dd0a95543901366b83c1c1a0bfe04541fdefb8c

commit 5dd0a95543901366b83c1c1a0bfe04541fdefb8c
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Aug 30 16:31:28 2017

🏡 Modern style for the personalised sign in promo

Updates the "Continue As" sign in promo to the modern style.

Also adds a few fixes to the that promo:
- Use the actual description text for the accessibility announcement
- Use the correct background for the non modern card (it's slightly
grayer than the regular suggestion cards)

Bug:  754529 
Change-Id: Ic7873283992f2bf1cf4b5dc93c82b62f76f052fb
Reviewed-on: https://chromium-review.googlesource.com/643288
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498492}
[add] https://crrev.com/5dd0a95543901366b83c1c1a0bfe04541fdefb8c/chrome/android/java/res/layout/personalized_signin_promo_view_modern_content_suggestions.xml
[modify] https://crrev.com/5dd0a95543901366b83c1c1a0bfe04541fdefb8c/chrome/android/java/res/layout/personalized_signin_promo_view_ntp_content_suggestions.xml
[modify] https://crrev.com/5dd0a95543901366b83c1c1a0bfe04541fdefb8c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/5dd0a95543901366b83c1c1a0bfe04541fdefb8c/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java
[modify] https://crrev.com/5dd0a95543901366b83c1c1a0bfe04541fdefb8c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java

Tests will be added as follow up later.