Separate compile and test pipelines to make pipelines cleaner and easy to maintain.
I'd suggest creating sub-bugs for breakdown tasks so that we could target at specific tasks instead of this general one.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5ddc471291e27a4040ae4854aab3325de37a428c commit 5ddc471291e27a4040ae4854aab3325de37a428c Author: Chan <chanli@chromium.org> Date: Wed Aug 23 00:39:03 2017 [Findit] Separate logic of creating a revert to a service module. Bug: 754527 , 757654 Change-Id: Ifd34f032c6826df0e5581bad0d359c268f9930d3 Reviewed-on: https://chromium-review.googlesource.com/622280 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/send_notification_to_irc_pipeline.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [add] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/revert_test.py [add] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/revert.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/submit_revert_cl_pipeline.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/906c23f989d613e6d8322be48fcf62ca56597909 commit 906c23f989d613e6d8322be48fcf62ca56597909 Author: Chan <chanli@chromium.org> Date: Fri Aug 25 23:53:00 2017 [Findit] Refactor detect_first_failure_pipeline 1. Move the logic of the pipeline to a separate service module 2. Move the logic of examing current failure to build_failure_analysis_pipelines (before pipelines) Bug: 754527 , 757657 Change-Id: Iad16582294dc8e40c90e1741c8e20647511cf6d6 Reviewed-on: https://chromium-review.googlesource.com/620008 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/services/test/gtest_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/detect_first_failure_pipeline.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_failure_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/services/gtest.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_util.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_failure_analysis_pipelines.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/handlers/test/process_failure_analysis_requests_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/analyze_build_failure_pipeline.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/handlers/test/build_failure_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_util_test.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_failure.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8f4c53e385b8eca179e1887320466d653fc980ab commit 8f4c53e385b8eca179e1887320466d653fc980ab Author: Chan <chanli@chromium.org> Date: Mon Sep 25 21:23:18 2017 [Findit] Start new pipelines for compile failures. Bug: 754527 , 764535 Change-Id: I6e3cf4c0d8bad0770b079692eb5e977ec45b5733 Reviewed-on: https://chromium-review.googlesource.com/680001 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/8f4c53e385b8eca179e1887320466d653fc980ab/appengine/findit/waterfall/build_failure_analysis_pipelines.py [modify] https://crrev.com/8f4c53e385b8eca179e1887320466d653fc980ab/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py
Comment 1 by chanli@chromium.org
, Aug 21 2017