New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754522 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Get per-RPC metrics

Project Member Reported by pho...@chromium.org, Aug 11 2017

Issue description

Two things needed for this:

- Add an argument to the http request which indicates which RPC was called. This will subsequently show up in the apache access logs.
- Improve the apache_access_log_metrics script to parse out the particular RPC that was called and add that into a metric field.
 

Comment 1 by pho...@chromium.org, Aug 11 2017

Labels: Hotlist-Fixit

Comment 2 by pho...@chromium.org, Aug 15 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f28a816878ea69fc2f7fb84d51b319eff4f218a2

commit f28a816878ea69fc2f7fb84d51b319eff4f218a2
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Aug 16 09:05:57 2017

[autotest] Add RPC method to request arguments for RPCs.

This is purely for informative purposes.

BUG= chromium:754522 
TEST=None

Change-Id: I427f7d318432482d2899ac0a19869631f2db4a7d
Reviewed-on: https://chromium-review.googlesource.com/612599
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/f28a816878ea69fc2f7fb84d51b319eff4f218a2/frontend/afe/json_rpc/proxy.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d45cf27fd48b25c304b7ebe830f399321c3c0c27

commit d45cf27fd48b25c304b7ebe830f399321c3c0c27
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Aug 18 10:14:01 2017

[autotest] Parse RPC method from access logs

Parse out the Method= query string from any /rpc logs, if present. Added two new
metrics for RPC access log metrics, broken down by method.

BUG= chromium:754522 
TEST=Unit tests still pass

Change-Id: Id54d74ca749ff13b05332e0f8e275940e09fdee6
Reviewed-on: https://chromium-review.googlesource.com/614791
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d45cf27fd48b25c304b7ebe830f399321c3c0c27/site_utils/stats/apache_access_log_metrics_unittest.py
[modify] https://crrev.com/d45cf27fd48b25c304b7ebe830f399321c3c0c27/site_utils/stats/apache_access_log_metrics.py

Status: Verified (was: Started)

Sign in to add a comment