New issue
Advanced search Search tips

Issue 754515 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Check failed: GetSuddenTerminationDisablerState(disabler_type) != present (1 vs. 1)

Project Member Reported by dalecur...@chromium.org, Aug 11 2017

Issue description

Triggers if you hit reload after a renderer DCHECK crashes. For me this was ToT plus trying to load https://www.twitch.tv/dota2ti it hit a DCHECK in "FATAL:WrapperVisitor.h(86)] Check failed: false." which brought down the renderer, then hitting reload killed browser :|

[136618:136618:0810/170451.011839:FATAL:render_frame_host_impl.cc(2594)] Check failed: GetSuddenTerminationDisablerState(disabler_type) != present (1 vs. 1)
#0 0x7f6670ea3947 base::debug::StackTrace::StackTrace()
#1 0x7f6670eca8c1 logging::LogMessage::~LogMessage()
#2 0x7f666e3f8c74 content::RenderFrameHostImpl::OnSuddenTerminationDisablerChanged()
#3 0x7f666e3f8af6 _ZN3IPC8MessageTI50FrameHostMsg_SuddenTerminationDisablerChanged_MetaNSt3__15tupleIJbhEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FvbhEEEbPKNS_7MessageEPT_PT0_PT1_T2_
#4 0x7f666e3ef6e4 content::RenderFrameHostImpl::OnMessageReceived()
#5 0x7f666e5e1499 content::RenderProcessHostImpl::OnMessageReceived()
#6 0x7f6670094b05 IPC::ChannelProxy::Context::OnDispatchMessage()
#7 0x7f6670ea418b base::debug::TaskAnnotator::RunTask()
#8 0x7f6670ed721d base::MessageLoop::RunTask()
#9 0x7f6670ed755b base::MessageLoop::DeferOrRunPendingTask()
#10 0x7f6670ed78c4 base::MessageLoop::DoWork()
#11 0x7f6670ed9749 base::MessagePumpGlib::Run()
#12 0x7f6670ed6c2a base::MessageLoop::Run()
#13 0x7f6670f0aac7 base::RunLoop::Run()
#14 0x556ae31a450e ChromeBrowserMainParts::MainMessageLoopRun()
#15 0x7f666e2b0892 content::BrowserMainLoop::RunMainMessageLoopParts()
#16 0x7f666e2b396b content::BrowserMainRunnerImpl::Run()
#17 0x7f666e2abc88 content::BrowserMain()
#18 0x7f666eb693aa content::RunNamedProcessTypeMain()
#19 0x7f666eb69d30 content::ContentMainRunnerImpl::Run()
#20 0x7f66713efe23 service_manager::Main()
#21 0x7f666eb68792 content::ContentMain()
#22 0x556ae2af7d6c ChromeMain
#23 0x7f666465ef45 __libc_start_main
#24 0x556ae2af7bbf <unknown>

Received signal 6
#0 0x7f6670ea3947 base::debug::StackTrace::StackTrace()
#1 0x7f6670ea341f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f6671028330 <unknown>
#3 0x7f6664673c37 gsignal
#4 0x7f6664677028 abort
#5 0x7f6670ea1552 base::debug::BreakDebugger()
#6 0x7f6670ecad92 logging::LogMessage::~LogMessage()
#7 0x7f666e3f8c74 content::RenderFrameHostImpl::OnSuddenTerminationDisablerChanged()
#8 0x7f666e3f8af6 _ZN3IPC8MessageTI50FrameHostMsg_SuddenTerminationDisablerChanged_MetaNSt3__15tupleIJbhEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FvbhEEEbPKNS_7MessageEPT_PT0_PT1_T2_
#9 0x7f666e3ef6e4 content::RenderFrameHostImpl::OnMessageReceived()
#10 0x7f666e5e1499 content::RenderProcessHostImpl::OnMessageReceived()
#11 0x7f6670094b05 IPC::ChannelProxy::Context::OnDispatchMessage()
#12 0x7f6670ea418b base::debug::TaskAnnotator::RunTask()
#13 0x7f6670ed721d base::MessageLoop::RunTask()
#14 0x7f6670ed755b base::MessageLoop::DeferOrRunPendingTask()
#15 0x7f6670ed78c4 base::MessageLoop::DoWork()
#16 0x7f6670ed9749 base::MessagePumpGlib::Run()
#17 0x7f6670ed6c2a base::MessageLoop::Run()
#18 0x7f6670f0aac7 base::RunLoop::Run()
#19 0x556ae31a450e ChromeBrowserMainParts::MainMessageLoopRun()
#20 0x7f666e2b0892 content::BrowserMainLoop::RunMainMessageLoopParts()
#21 0x7f666e2b396b content::BrowserMainRunnerImpl::Run()
#22 0x7f666e2abc88 content::BrowserMain()
#23 0x7f666eb693aa content::RunNamedProcessTypeMain()
#24 0x7f666eb69d30 content::ContentMainRunnerImpl::Run()
#25 0x7f66713efe23 service_manager::Main()
#26 0x7f666eb68792 content::ContentMain()
#27 0x556ae2af7d6c ChromeMain
#28 0x7f666465ef45 __libc_start_main
#29 0x556ae2af7bbf <unknown>
  r8: ffffa4d65236f2f0  r9: ffffa4d65236f2e0 r10: 0000000000000008 r11: 0000000000000206
 r12: 00007fffc11cdf90 r13: 000000000000009c r14: 00007fffc11cdf88 r15: 00007fffc11cdf80
  di: 00000000000215aa  si: 00000000000215aa  bp: 00007fffc11cdb30  bx: 00007fffc11cdb30
  dx: 0000000000000006  ax: 0000000000000000  cx: 00007f6664673c37  sp: 00007fffc11cd988
  ip: 00007f6664673c37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

Seems to be from d9680cb31e92b038b14f41c6f462341d16c9c321
 
Cc: fmea...@chromium.org
Owner: oysteine@chromium.org
Assigning it to oysteine@, feel free to bounce it back.

Comment 2 by cburn@google.com, Aug 16 2017

This happens for me too.
Repro Steps:
Open a debug build of Chrome and leave the new tab page open.
Open the Task Manager and kill the new tab page.
Click Reload on the sad tab page. 
Me 3. Also, does this have a bug component? Are you just using Hotlist-GRC?
 Issue 758268  has been merged into this issue.
fmeawad@ can you pick this back up? oysteine@ seems MIA and DCHECKs like this should be fixed or removed right away.
On it.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d6c1f038ae7e8c13e19c3138cee0709a2c3bf4

commit b7d6c1f038ae7e8c13e19c3138cee0709a2c3bf4
Author: Oystein Eftevaag <oysteine@chromium.org>
Date: Fri Aug 25 00:30:47 2017

[TabDiscarding] Reset the sudden termination features flag when renderer dies

Without this a DCHECK fires when the new process re-sends these flags.

Originally added in https://chromium-review.googlesource.com/c/chromium/src/+/562616

R=JAM
BUG= 754515 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie14dec6755c64c0a5328923f149d17a3ca85a710
Reviewed-on: https://chromium-review.googlesource.com/630243
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497256}
[modify] https://crrev.com/b7d6c1f038ae7e8c13e19c3138cee0709a2c3bf4/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b7d6c1f038ae7e8c13e19c3138cee0709a2c3bf4/content/browser/frame_host/render_frame_host_impl_browsertest.cc

Status: Fixed (was: Assigned)
Thanks!

Sign in to add a comment