New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754509 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
gambard@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Fake search box elongates out of the screen.

Project Member Reported by vbhatso...@chromium.org, Aug 11 2017 
App Version: 61.0.3163.40 Beta
iOS Version: 9.3.5
Device: iPhone 5 , iPhone 5S (smaller devices)

Steps to reproduce:
1. Launch app in landscape mode.
2. Go to Recent tabs. Long Press on the arrow to bring up the context menu.
3. Change the device orientation to portrait mode.
4. Tap on Open All from Context menu

Observed results:
Fake search box bleeds out of the screen.

Expected results:
Fake search box should be fit to screen.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version):  M60  - Yes
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes - M61
Link to video/image: https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClWlI1emEyWTBvc3M/view?usp=sharing

Comment 1 by gambard@chromium.org, Aug 11 2017

Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Nice catch!

Comment 2 by mvanouwe...@chromium.org, Aug 14 2017

Labels: zine-triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc082be814ea18129d0dfa1d93867b008b223de

commit 0bc082be814ea18129d0dfa1d93867b008b223de
Author: gambard <gambard@chromium.org>
Date: Wed Aug 16 08:44:19 2017

Resize the omnibox based on new width

When rotating the device, the width used to calculate the new width of
the omnibox should be the one which will be used after, not the
current one.

Bug:  754509 
Change-Id: Iac83bc40494e5da757bacf84fd266995dc7483c1
Reviewed-on: https://chromium-review.googlesource.com/612175
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494727}
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[add] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/ntp_home_constant.h
[add] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/ntp_home_constant.mm
[add] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[add] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/ntp_home_provider_test_singleton.h
[add] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/content_suggestions/ntp_home_provider_test_singleton.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/0bc082be814ea18129d0dfa1d93867b008b223de/ios/clean/chrome/browser/ui/ntp/ntp_home_header_mediator.mm

Comment 4 by gambard@chromium.org, Aug 16 2017

Status: Fixed (was: Assigned)

Comment 5 by shbarezer@chromium.org, Aug 22 2017

Status: Verified (was: Fixed)
Verified in 62.0.3193.0 canary, iPhone 5S iOS 9.3.5.
Looks good.
►

Sign in to add a comment