Notification layout is broken when any Chrome extension app is installed. |
|||||
Issue descriptionChrome OS version: 62.0.3176.0, dev build Platform version: 9827.0.0, dev channel caroline device M-62 build Steps to reproduce the problem: 1. Goto Chrome extensions (Chrome web store), try to install any extension app like Postman App> Add to chrome> Add App. 2. Observe the notification message. Its layout is broken, notification title is missing. 3. Now try to install another extension and observe the notification. 4. This new notification overwrites the previous one (i.e the notification related chrome app installation). What is the expected behavior? Notification layout should not be broken and must contain the relevant details in it. It shouldn't overwrite the previous one. Refer the attachment.
,
Aug 15 2017
Thank you for reporting. > It shouldn't overwrite the previous one. It seems this part is unchanged from old style notification. (The behavior didn't change when I disabled new style by chrome://flags#enable-message-center-new-style-notification)
,
Aug 15 2017
,
Aug 15 2017
Now I see that Screenshot notification overwrites the previous one (i.e. previous Screenshot notification). And, image icon on RHS of the notification also needs to be corrected. Seen with new style notification flag enabled, on Chrome OS 9841.0.0, 62.0.3176.0 dev build.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b782188f39f80bc6347418d858a434afd5f8c8bb commit b782188f39f80bc6347418d858a434afd5f8c8bb Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Aug 18 03:33:29 2017 Add display_source to extension installed notification. Extension installed notification did not have |display_source|, which led to broken layout in MD notification. This CL sets "Extensions" as |display_source|, and also sets |accent_color| which is only effective in MD notification (no regression in MD notification disabled). TEST=manual BUG= 754508 Change-Id: Iec0dff6dd3c897f770007fe805bad8f0b257e3e2 Reviewed-on: https://chromium-review.googlesource.com/618433 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#495450} [modify] https://crrev.com/b782188f39f80bc6347418d858a434afd5f8c8bb/chrome/app/generated_resources.grd [modify] https://crrev.com/b782188f39f80bc6347418d858a434afd5f8c8bb/chrome/browser/ui/extensions/extension_installed_notification.cc
,
Aug 18 2017
,
Aug 18 2017
Filed https://crbug.com/756710 as overwriting problem is a separate problem and not regression. Thank you for reporting.
,
Nov 8 2017
Verified on M64 dev build (10106.0.0, 64.0.3261.0). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by joh...@chromium.org
, Aug 14 2017Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)