New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754504 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Scan does not start up when Mobile data settings opened

Project Member Reported by khorimoto@chromium.org, Aug 10 2017

Issue description

Opening up the "Mobile data" section of settings should trigger a scan, but this does not currently happen.

Note that this *does* happen when the Wi-Fi section of settings is opened.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbb968870e812ad73c3df9c9302ffb99edb19b1a

commit bbb968870e812ad73c3df9c9302ffb99edb19b1a
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Aug 16 02:56:16 2017

[CrOS Tether] Start a scan when viewing the Tether subpage.

Previously, Wi-Fi networks were the only scannable network type, so the
internet subpage would only kick off scans when the Wi-Fi subpage was
visible. Now that tether networks can also be found via a scan, we
should request a scan when we open that page.

Bug:  754504 , 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84e4b294efd7c404353fe0ea8f5edf2b12bcf90b
Reviewed-on: https://chromium-review.googlesource.com/616244
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494680}
[modify] https://crrev.com/bbb968870e812ad73c3df9c9302ffb99edb19b1a/chrome/browser/resources/settings/internet_page/internet_subpage.js

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9056f36c55ddb64afbb120e29ff19ce073ac66a9

commit 9056f36c55ddb64afbb120e29ff19ce073ac66a9
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Aug 16 23:39:23 2017

[CrOS Tether] Start a scan when viewing the Tether subpage.

Previously, Wi-Fi networks were the only scannable network type, so the
internet subpage would only kick off scans when the Wi-Fi subpage was
visible. Now that tether networks can also be found via a scan, we
should request a scan when we open that page.

TBR=khorimoto@google.com

(cherry picked from commit bbb968870e812ad73c3df9c9302ffb99edb19b1a)

Bug:  754504 , 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84e4b294efd7c404353fe0ea8f5edf2b12bcf90b
Reviewed-on: https://chromium-review.googlesource.com/616244
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494680}
Reviewed-on: https://chromium-review.googlesource.com/618222
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#615}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9056f36c55ddb64afbb120e29ff19ce073ac66a9/chrome/browser/resources/settings/internet_page/internet_subpage.js

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment