New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Scanning indicator at top of network list doesn't animate for Tether scan

Project Member Reported by lesliewatkins@chromium.org, Aug 10 2017

Issue description

Chrome Version: 62.0.3182.0
OS: Chrome

What steps will reproduce the problem?
(1) Enable Tether
(2) Open System Tray, then network list
(3) Wait for a Tether scan to start

What is the expected result?
The blue line at the top of the network list should animate, as it does for WiFi scans.

What happens instead?
It doesn't animate.
 
Cc: lesliewatkins@chromium.org
Owner: lesliewatkins@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Leslie - she already knows the fix for this issue.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c8c33283670cd828c7ca92b4f2b908911b07a1

commit 43c8c33283670cd828c7ca92b4f2b908911b07a1
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Wed Aug 16 19:20:11 2017

Show progress bar in system tray when Tether device is scanning.

Bug:  754491 , 672263
Change-Id: I437f07207e36083ee310197843518d1fd398f525
Reviewed-on: https://chromium-review.googlesource.com/615666
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494892}
[modify] https://crrev.com/43c8c33283670cd828c7ca92b4f2b908911b07a1/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/43c8c33283670cd828c7ca92b4f2b908911b07a1/chromeos/components/tether/host_scan_scheduler.cc
[modify] https://crrev.com/43c8c33283670cd828c7ca92b4f2b908911b07a1/chromeos/components/tether/host_scan_scheduler_unittest.cc

Labels: Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 17 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2437a4f66fc4e452c1aa74987cf92d3dadb598f5

commit 2437a4f66fc4e452c1aa74987cf92d3dadb598f5
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 17 21:03:38 2017

Show progress bar in system tray when Tether device is scanning.

TBR=lesliewatkins@chromium.org

(cherry picked from commit 43c8c33283670cd828c7ca92b4f2b908911b07a1)

Bug:  754491 , 672263
Change-Id: I437f07207e36083ee310197843518d1fd398f525
Reviewed-on: https://chromium-review.googlesource.com/615666
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494892}
Reviewed-on: https://chromium-review.googlesource.com/619786
Cr-Commit-Position: refs/branch-heads/3163@{#647}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2437a4f66fc4e452c1aa74987cf92d3dadb598f5/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/2437a4f66fc4e452c1aa74987cf92d3dadb598f5/chromeos/components/tether/host_scan_scheduler.cc
[modify] https://crrev.com/2437a4f66fc4e452c1aa74987cf92d3dadb598f5/chromeos/components/tether/host_scan_scheduler_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment