New issue
Advanced search Search tips

Issue 754477 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Populate quic_connection_error in NetErrorDetails in more cases

Project Member Reported by rch@chromium.org, Aug 10 2017

Issue description

Sometimes a request fails with ERR_QUIC_PROTOCOL_ERROR, but the quic_connection_error field of NetErrorDetails is QUIC_NO_ERROR. While there are some valid reasons for this to happen (for example if a steam is RST by the peer) there are probably some edge cases we're missing, perhaps when there is no underlying QUIC stream.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e316e48b3ece4de03e7f958d82459adbd925b6b7

commit e316e48b3ece4de03e7f958d82459adbd925b6b7
Author: Ryan Hamilton <rch@chromium.org>
Date: Thu Aug 17 02:48:53 2017

Populate quic_connection_error in NetErrorDetails even if the handshake 
has not been confirmed. 

Presumably, this request will be retried over TCP and no error details
will be needed, but we should be consistent in
any case.

BUG= 754477 

Change-Id: I3f939b1f9b58a7b57b219a892ae7fb8ba646a450
Reviewed-on: https://chromium-review.googlesource.com/611257
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495057}
[modify] https://crrev.com/e316e48b3ece4de03e7f958d82459adbd925b6b7/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/e316e48b3ece4de03e7f958d82459adbd925b6b7/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/e316e48b3ece4de03e7f958d82459adbd925b6b7/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/e316e48b3ece4de03e7f958d82459adbd925b6b7/net/quic/chromium/quic_network_transaction_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f19726fb04729c36d5b4cd7c4d9931a151bee7

commit 75f19726fb04729c36d5b4cd7c4d9931a151bee7
Author: Ryan Hamilton <rch@chromium.org>
Date: Thu Aug 17 14:00:07 2017

Report the QUIC connection error in NetErrorDetails when the QUIC
connection fails before actually creating a stream.

Change-Id: Idcb6f0b1a13aebdf4815b2a2ec89246c23bc56a1

Bug:  754477 
Change-Id: Idcb6f0b1a13aebdf4815b2a2ec89246c23bc56a1
Reviewed-on: https://chromium-review.googlesource.com/617813
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495162}
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/bidirectional_stream.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/bidirectional_stream.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_network_transaction.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_network_transaction.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_job.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_request_unittest.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/http/http_stream_factory_test_util.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/75f19726fb04729c36d5b4cd7c4d9931a151bee7/net/quic/chromium/quic_stream_factory_test.cc

Comment 3 by rch@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment