Change to "Mobile data" quick settings when no networks available |
||||||||||||||||
Issue descriptionCurrently, when no mobile networks are available, the Mobile data section of quick settings is empty. This can appear broken to users. A screenshot of the existing UX is attached to this bug. We've decided to add a label in this case that indicates that there are no hosts. The string would read something like "No mobile data networks in range". If we are actively scanning, should the label read differently? Something like "Searching for nearby mobile networks"? Also, the string deadline has passed for M-61. What is the process for expediting the localization process?
,
Aug 22 2017
Requesting merge for the string CL. The rest of this feature is coming in future CLs.
,
Aug 22 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22 2017
,
Aug 22 2017
Approving merge to M61 Chrome OS.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d27e78c4a81a1619f6f8bfab545cb3038dba3ac7 commit d27e78c4a81a1619f6f8bfab545cb3038dba3ac7 Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Aug 22 20:25:28 2017 [CrOS Tether] Add strings to be displayed in the quick settings tray. These strings will not be used until a follow-up CL, but I'm adding this CL now so that we can get translations started ASAP. The M-61 branch date has already passed, so these translations need to be expedited. TBR=khorimoto@google.com (cherry picked from commit 8b228f16bba5599923236a6721cfc7cff1c3178b) Bug: 754465 , 672263 Change-Id: I50324e4386b0357433e7b902bfa9b21002caa9b7 Reviewed-on: https://chromium-review.googlesource.com/625376 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496362} Reviewed-on: https://chromium-review.googlesource.com/627376 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#776} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d27e78c4a81a1619f6f8bfab545cb3038dba3ac7/ash/ash_strings.grd
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2 commit 56f8b13c543feea07d4ed99ce58ddec46bbd0ae2 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Aug 23 01:45:42 2017 [CrOS Tether] Make changes to Mobile data Quick Settings. If Celluar is available on the device (i.e., the device has its own LTE connection), this CL leaves things as they are. If Cellular is not available on the device, (1) If Mobile data is disabled via toggle, display "Mobile data is turned off." (2) If Mobile data is disabled due to Bluetooth being off, display "Enabling mobile data will enable Bluetooth." (3) If Mobile data is enabled but no host devices have been scanned, display "No mobile devices found." Note: This CL also fixes an issue when Wi-Fi is disabled. The string "Wi-Fi is turned off" is supposed to be displayed when Wi-Fi is off but there are no nearby networks. However, there was a bug which prevented this string from being displayed if there was another network (i.e., Ethernet/Tether/Cellular) was available. Bug: 754465 , 672263 Change-Id: I947f36974c6407ebe69b6483679f042a9315141d Reviewed-on: https://chromium-review.googlesource.com/627256 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496551} [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/ash/system/network/network_icon.cc [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/ash/system/network/network_icon.h [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/ash/system/network/network_icon_unittest.cc [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/ash/system/network/network_list.cc [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/ash/system/network/network_list.h [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/chrome/browser/chromeos/status/network_menu.cc [modify] https://crrev.com/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2/chromeos/network/network_state_handler.h
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207d2a6bbc53c4ae6614a419883fdf1db63736c7 commit 207d2a6bbc53c4ae6614a419883fdf1db63736c7 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Aug 23 01:52:08 2017 [CrOS Tether] Make changes to Mobile data Quick Settings. If Celluar is available on the device (i.e., the device has its own LTE connection), this CL leaves things as they are. If Cellular is not available on the device, (1) If Mobile data is disabled via toggle, display "Mobile data is turned off." (2) If Mobile data is disabled due to Bluetooth being off, display "Enabling mobile data will enable Bluetooth." (3) If Mobile data is enabled but no host devices have been scanned, display "No mobile devices found." Note: This CL also fixes an issue when Wi-Fi is disabled. The string "Wi-Fi is turned off" is supposed to be displayed when Wi-Fi is off but there are no nearby networks. However, there was a bug which prevented this string from being displayed if there was another network (i.e., Ethernet/Tether/Cellular) was available. TBR=khorimoto@google.com (cherry picked from commit 56f8b13c543feea07d4ed99ce58ddec46bbd0ae2) Bug: 754465 , 672263 Change-Id: I947f36974c6407ebe69b6483679f042a9315141d Reviewed-on: https://chromium-review.googlesource.com/627256 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496551} Reviewed-on: https://chromium-review.googlesource.com/627663 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#797} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/ash/system/network/network_icon.cc [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/ash/system/network/network_icon.h [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/ash/system/network/network_icon_unittest.cc [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/ash/system/network/network_list.cc [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/ash/system/network/network_list.h [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/chrome/browser/chromeos/status/network_menu.cc [modify] https://crrev.com/207d2a6bbc53c4ae6614a419883fdf1db63736c7/chromeos/network/network_state_handler.h
,
Aug 23 2017
,
Sep 5 2017
jennschen@ requested screenshots of this change. They're attached to this comment.
,
Jan 22 2018
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 22 2017