Content layer depends on the service-manager. Implementation steps include: - Implement sandboxed process launch. - Bring-up service_manager_unittests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bb0f9747526674cba7adc1f0adaef400e519d68 commit 2bb0f9747526674cba7adc1f0adaef400e519d68 Author: Wez <wez@chromium.org> Date: Tue Aug 15 23:11:30 2017 Move services/catalog/data to .../test_data, and add Fuchsia OS. Bug: 754449 Change-Id: I492f88abfb952f039692c3fa44458653c21b9a03 Reviewed-on: https://chromium-review.googlesource.com/615849 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#494596} [modify] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/BUILD.gn [modify] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/entry_unittest.cc [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/connection_spec [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/instance [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/malformed [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/required_files [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/serialization [rename] https://crrev.com/2bb0f9747526674cba7adc1f0adaef400e519d68/services/catalog/test_data/simple
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75fa6bc9dc4c518164a885ebe9378a12f13b65cd commit 75fa6bc9dc4c518164a885ebe9378a12f13b65cd Author: Wez <wez@chromium.org> Date: Thu Aug 17 04:33:19 2017 Make Service Manager unit-tests compile for Fuchsia. - Add OS_FUCHSIA specialization of a couple of code-paths. - Add a missing error-code stringification. - Add the service_manager_unittests target to the bots to compile. Bug: 754449 Change-Id: I13baaea1e7b0f3e1ec9354e14c401648fc54cff9 Reviewed-on: https://chromium-review.googlesource.com/611747 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#495072} [modify] https://crrev.com/75fa6bc9dc4c518164a885ebe9378a12f13b65cd/base/process/process_handle_fuchsia.cc [modify] https://crrev.com/75fa6bc9dc4c518164a885ebe9378a12f13b65cd/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/75fa6bc9dc4c518164a885ebe9378a12f13b65cd/services/service_manager/tests/util.cc [modify] https://crrev.com/75fa6bc9dc4c518164a885ebe9378a12f13b65cd/testing/buildbot/chromium.fyi.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2 commit 27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2 Author: Wez <wez@chromium.org> Date: Thu Aug 17 21:00:42 2017 Enable service_manager_unittests. This mainly requires fixing some test process-launching code to correctly invoke ChildProcessLaunched() to allow us to clean up the client IPC handle from PlatformChannelPair. Bug: 754449 Change-Id: I31f71a006d144ae9c28b6a2db3cb148a5e328917 Reviewed-on: https://chromium-review.googlesource.com/618183 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#495317} [modify] https://crrev.com/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2/mojo/edk/embedder/platform_channel_pair.cc [modify] https://crrev.com/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2/services/service_manager/runner/host/service_process_launcher.cc [modify] https://crrev.com/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2/services/service_manager/tests/util.cc [modify] https://crrev.com/27c5f5c203bf6d5c5f226c9f4a26d61b2463bae2/testing/buildbot/chromium.fyi.json
Re-opening since tests seem unstable.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e71496c33ec0403c419a08fdaa95b0b31e066edb commit e71496c33ec0403c419a08fdaa95b0b31e066edb Author: Wez <wez@chromium.org> Date: Fri Aug 18 17:56:16 2017 Add filter for service_manager_unittests. We are seeing the unit-tests flake frequently, so speculatively filter out some crash-related tests in the hope that they are the cause. Bug: 754449 Change-Id: I00a4c91723fbc57d4f0ee3ce81a8a7dc9c17ab07 Reviewed-on: https://chromium-review.googlesource.com/621466 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#495611} [modify] https://crrev.com/e71496c33ec0403c419a08fdaa95b0b31e066edb/testing/buildbot/chromium.fyi.json [add] https://crrev.com/e71496c33ec0403c419a08fdaa95b0b31e066edb/testing/buildbot/filters/fuchsia.service_manager_unittests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dae8437e7c24c6cc59cdbc1840bcc530ff376df commit 0dae8437e7c24c6cc59cdbc1840bcc530ff376df Author: Wez <wez@chromium.org> Date: Mon Aug 21 19:32:38 2017 Generalise exclusion of service-manager Crash tests Bug: 754449 Change-Id: Ifd8ff8092d86be334b52639666f890e71e39bebb Reviewed-on: https://chromium-review.googlesource.com/622508 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#496023} [modify] https://crrev.com/0dae8437e7c24c6cc59cdbc1840bcc530ff376df/testing/buildbot/filters/fuchsia.service_manager_unittests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76228602b256704db5aba321ad874f12e8a5ac8c commit 76228602b256704db5aba321ad874f12e8a5ac8c Author: Wez <wez@chromium.org> Date: Tue Jun 05 07:06:07 2018 Cleanup some service_manager_unittests tests, and remove filter. - Fix ServiceProcessLauncherTest.StartJoin to actually fail if child process launch fails. - Fix ServiceProcessLauncherTest.StartJoin to look for the service binary in the correct location, under Fuchsia. - Remove an unused call to PathService::Get(DIR_MODULE). - Remove the filter on LifecycleTest.*Crash*, which appear to pass cleanly now. Bug: 754449 Change-Id: Ib1e16cce24f2278b8f8e99692586366ba0248ba9 Reviewed-on: https://chromium-review.googlesource.com/1084010 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#564387} [modify] https://crrev.com/76228602b256704db5aba321ad874f12e8a5ac8c/services/service_manager/runner/host/service_process_launcher_unittest.cc [modify] https://crrev.com/76228602b256704db5aba321ad874f12e8a5ac8c/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/76228602b256704db5aba321ad874f12e8a5ac8c/testing/buildbot/chromium.linux.json [modify] https://crrev.com/76228602b256704db5aba321ad874f12e8a5ac8c/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/9836fb9466ef3d9e4311b12db2bfc97bbd572b3d/testing/buildbot/filters/fuchsia.service_manager_unittests.filter [modify] https://crrev.com/76228602b256704db5aba321ad874f12e8a5ac8c/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc98dbfd177787df0d527e2f131c00f82b03e238 commit dc98dbfd177787df0d527e2f131c00f82b03e238 Author: Wez <wez@chromium.org> Date: Tue Jun 05 19:49:42 2018 [Mojo] Channel::RemoteProcessLaunched->RemoteProcessLaunchAttempted. Replaces the Channel::RemoteProcessLaunched API, which callers had to invoke only if they successfully launched a process with the Channel handle, with RemoteProcessLaunchAttempted, which must always be called regardless of whether process-launch was successful, so long as it was attempted with base::LaunchProcess. This is required under Fuchsia, where the remote endpoint handle is transferred, rather than cloned, and the LaunchProcess API consumes the handle even on failure, for consistency. On POSIX and Windows the effect is just to close the remote endpoint handle earlier in the case of failure to launch. Bug: 848028 , 754449 Change-Id: Ia79efebdc8b629f3d579a76c941283d461980e4c Reviewed-on: https://chromium-review.googlesource.com/1086385 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564620} [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/content/browser/child_process_launcher_helper.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/mojo/edk/system/invitation_unittest.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/mojo/public/cpp/platform/platform_channel.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/mojo/public/cpp/platform/platform_channel.h [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/mojo/public/cpp/system/tests/invitation_unittest.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/services/service_manager/runner/host/service_process_launcher.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/services/service_manager/runner/host/service_process_launcher_unittest.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/dc98dbfd177787df0d527e2f131c00f82b03e238/services/service_manager/tests/util.cc
Comment 1 by w...@chromium.org
, Aug 10 2017