New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754447 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

browser_side_navigation_interactive_ui_tests failing on chromium.mac/Mac10.11 Tests

Project Member Reported by wkorman@chromium.org, Aug 10 2017

Issue description

browser_side_navigation_interactive_ui_tests failing on chromium.mac/Mac10.11 Tests

Builders failed on: 
- Mac10.11 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests

Suspect CL: https://chromium-review.googlesource.com/c/592313

I will try a speculative revert.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/744be8fe99a4817127e5f1ff8715556fde6ecd1a

commit 744be8fe99a4817127e5f1ff8715556fde6ecd1a
Author: Walter Korman <wkorman@chromium.org>
Date: Thu Aug 10 21:37:49 2017

Revert "Add tests to ensure browser shortcuts should be handled in fullscreen"

This reverts commit a4795877b3e11ab9a1193397b13c18e402f8e7f4.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add tests to ensure browser shortcuts should be handled in fullscreen
> 
> This change adds several tests to ensure in both browser fullscreen and HTML
> fullscreen, if preventDefault() is not performed, browser shortcuts should still
> take effect.
> 
> ShortcutsShouldTakeEffectInJsFullscreen test let the about:blank page enter HTML
> fullscreen by using document.body.webkitRequestFullscreen().
> ShortcutsShouldTakeEffectInBrowserFullscreen test uses default page and "F11"
> shortcut to test the behavior in browser fullscreen.
> 
> After change https://codereview.chromium.org/2781633003, in fullscreen, most of
> the shortcuts will be sent to renderer first. So various observing-patterns are
> included in this change to detect the asynchronized actions.
> 
> Bug:  chromium:680809 ,  chromium:737307 
> Change-Id: I0e326d234bed1400882bf011331ab9b62f3adbc9
> Reviewed-on: https://chromium-review.googlesource.com/592313
> Commit-Queue: Zijie He <zijiehe@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#493500}

TBR=msw@chromium.org,zijiehe@chromium.org

Change-Id: I7ea477c7ab0cc2b5b8e575f4490366f6c66accc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:680809 ,  chromium:737307 ,  chromium:754447 
Reviewed-on: https://chromium-review.googlesource.com/610943
Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493553}
[modify] https://crrev.com/744be8fe99a4817127e5f1ff8715556fde6ecd1a/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc

Status: Fixed (was: Assigned)
This issue itself is fixed by disabling the flaky test case on Mac OSX.
The root cause is tracked by  http://crbug.com/740250 .

Sign in to add a comment