MD Extensions: investigate whether extensions_test_util.testIronIcons() is still needed |
||||
Issue descriptionAfter moving away from paper-icon-button, the only pages that still has <iron-icon>s are the item.html and detail_view.html page (with only 1 iron-icon each). This might mean extensions_test_util.testIronIcons() doesn't need to exist anymore.
,
Sep 7 2017
,
Sep 7 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edd6f17dc3b437d9f701e9a094ca81c0c3206b93 commit edd6f17dc3b437d9f701e9a094ca81c0c3206b93 Author: Scott Chen <scottchen@chromium.org> Date: Mon Sep 11 23:55:59 2017 MD Extensions: update the testIronIcons util function. It now also tests whether a valid icon is applied to paper-icon-button-light. Bug: 754446 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e9cc88c7b20c9a3795f69fc73a72f6c10d94751 Reviewed-on: https://chromium-review.googlesource.com/653658 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501102} [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/browser/resources/md_extensions/shortcut_input.html [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_item_test.js [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_sidebar_test.js [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_test_util.js [modify] https://crrev.com/edd6f17dc3b437d9f701e9a094ca81c0c3206b93/chrome/test/data/webui/extensions/extension_toolbar_test.js
,
Sep 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scottchen@chromium.org
, Sep 6 2017