New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Composition markers paint incorrectly in RTL text boxes

Project Member Reported by rlanday@chromium.org, Aug 10 2017

Issue description

As of 2017-08-10, we have a layout test for composition markers whose baseline expected behavior for RTL mode shows markers painting their underline and background highlight in different places:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/platform/win/editing/composition-marker-basic-expected.png

 
Related bug: spelling markers don't paint correctly under LTR text in RTL flow or RTL text in LTR flow inside a narrow text box with text-overflow: ellipsis set.

data:text/html, <div contenteditable style="width:40px; font: 12px; overflow:hidden; text-overflow:ellipsis;direction:rtl; white-space:nowrap">chorme</div>

The underline gets painted under the ellipsis instead of the word. I was hoping I could copy the spelling underline code and use it for composition markers since it handles all the composition-marker-basic.html cases, but unfortunately that breaks ellipsis-ltr-text-in-rtl-flow-underline-composition.html and ellipsis-rtl-text-in-ltr-flow-underline-composition.html.
Attaching the current behavior for a test case I'm about to add (testing LTR text in a truncated RTL box). Composition and spelling markers draw incorrectly (text match looks OK, assuming it's expected behavior to include the ellipsis).
ellipsis-ltr-text-in-rtl-flow-with-markers-actual.png
16.4 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55763e0ea9e80d2159bcc6dae71f5a9d801d2397

commit 55763e0ea9e80d2159bcc6dae71f5a9d801d2397
Author: Ryan Landay <rlanday@chromium.org>
Date: Thu Aug 17 19:55:12 2017

Add some layout tests for DocumentMarkers in truncated text boxes

I'm working on fixing some bugs with DocumentMarker painting in certain cases
involving mixing LTR and RTL text and inline text boxes truncated by ellipses.
I am going to split the bug fixes into at least two CLs. Adding these layout
tests (whose current behavior is incorrect) will make it easier for reviewers to
understand what behavior is being fixed by the bug fix CLs.

Bug:  754443 
Change-Id: Ief7602bcf06fa33bd2dd8f69d04a7ca910a6ffb5
Reviewed-on: https://chromium-review.googlesource.com/617411
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495289}
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-ltr-text-in-ltr-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-ltr-text-in-rtl-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-mixed-text-in-ltr-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-mixed-text-in-rtl-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-rtl-text-in-ltr-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/editing/ellipsis-rtl-text-in-rtl-flow-with-markers.html
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.txt
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.png
[add] https://crrev.com/55763e0ea9e80d2159bcc6dae71f5a9d801d2397/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8406579c9280c4c69b42d446232d712b65d9be

commit 5b8406579c9280c4c69b42d446232d712b65d9be
Author: Ryan Landay <rlanday@chromium.org>
Date: Tue Aug 22 02:37:18 2017

Fix composition marker painting in bi-directional text

Composition marker painting is currently broken for LTR text in an RTL text box
and vice-versa. The painting for the underlines and background highlighting are
both broken in different ways; background highlights appear to start in the
correct location, but then go the wrong way if the text box is truncated;
underlines are incorrect in a way that's difficult to fully describe. This CL
fixes these cases. 

Bug:  754443 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8baf26c81d06593e32db8d70b0cf8e0e2b39c7dc
Reviewed-on: https://chromium-review.googlesource.com/617613
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496184}
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/active-suggestion-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/composition-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/selection/text-selection-with-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/selection/text-selection-with-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/selection/text-selection-with-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac-retina/paint/selection/text-selection-with-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/active-suggestion-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/active-suggestion-marker-split-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/composition-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/composition-marker-split-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/mac/paint/selection/text-selection-with-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/active-suggestion-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/composition-marker-basic-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win7/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win7/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win7/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/LayoutTests/platform/win7/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/5b8406579c9280c4c69b42d446232d712b65d9be/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549f2e96cd864ec1e913695cb11f64913f564068

commit 549f2e96cd864ec1e913695cb11f64913f564068
Author: Ryan Landay <rlanday@chromium.org>
Date: Wed Aug 23 17:46:01 2017

Fix spell check marker painting in text boxes truncated by ellipses

Currently, spelling and grammar markers (they share the same painting code)
paint incorrectly in certain cases involving inline text boxes truncated by
ellipses and containing bi-directional text. This CL fixes these cases. The
layout test baseline updates in this CL illustrate the cases being fixed.

Bug:  754443 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I794c4634047e992e8950fa6d5712a3a7d0da49f4
Reviewed-on: https://chromium-review.googlesource.com/617413
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496728}
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline_spelling_markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/win/editing/ellipsis-rtl-text-in-ltr-flow-with-markers-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/549f2e96cd864ec1e913695cb11f64913f564068/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Labels: M-62
Status: Fixed (was: Assigned)

Sign in to add a comment