Removing third_party/libva broke os=chromeos on Linux builds |
||||||||
Issue description$ cat out/Release-cros/args.gn # Build arguments go here. Examples: # is_component_build = true # is_debug = false # See "gn args <out_dir> --list" for available build arguments. # dcheck_always_on = true is_component_build = true is_debug = false use_goma = true target_os = "chromeos" symbol_level = 0 Building this today fails; building before https://chromium.googlesource.com/chromium/src/+/c13a597516f19a1c7489b342cd8198ea173d5b68 succeeds. This is a useful developer config, so we should fix this build breakage.
,
Aug 10 2017
,
Aug 10 2017
Probably can be fixed by sudo apt-get install libva-dev ?
,
Aug 10 2017
In that case, is the install build deps sh script up to date? dcheng, maybe you just need to rerun that? (If not, we should update the script)
,
Aug 10 2017
I already tried installing libva-dev to see if that would make the error go away =) I suspect we'll need some tweak to the build flags. The error is: ../../media/gpu/jpeg_decode_accelerator_unittest.cc:151:2: error: The JpegDecodeAccelerator is not supported on this platform. #error The JpegDecodeAccelerator is not supported on this platform. ^
,
Aug 11 2017
,
Aug 11 2017
Sorry about this - I am ooo until next Monday JST but will look at this issue first thing. It seems like an #ifdef needs to be updated.
,
Aug 14 2017
Been able to reproduce the error. It is not the Chrome build itself that fails, but the jpeg_decode_accelerator_unittest. This particular flavor of Chrome OS does not support hardware JPEG and video decode acceleration (since neither libva nor v4l2 are used), so that test would not be able to run anyway. But getting a compilation error like this is clearly not very graceful. I have submitted https://chromium-review.googlesource.com/c/612924 which should fix this. Reviews appreciated, thanks!
,
Aug 18 2017
Issue 756485 has been merged into this issue.
,
Aug 23 2017
,
Aug 23 2017
Yah - that bot has been broken for a week, since https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/54289 (for some reason, Sheriff-o-matic doesn't report it, but build.chromium.org does + Sheriff-Chromium, so other sheriffs don't go hunting for this bug)
,
Aug 23 2017
https://chromium-review.googlesource.com/c/chromium/src/+/627958 should address this issue at the build level. The JDA unittest will not be built on platforms that do not support it.
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3244bc11b60f7478fc2adf93d85b21263470f395 commit 3244bc11b60f7478fc2adf93d85b21263470f395 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Aug 24 07:51:22 2017 Create a jpeg decoder instance by GpuJDAFactoryProvider in JDA unittest JDA unittest has created a jpeg decoder instance by a different method from GpuJpegDecodeAcceleratorFactoryProvider. It should rely on GpuJDAFactoryProvider::GetAcceleratorFactories(). BUG= chromium:746822 BUG= chromium:754442 TEST=JDA unittest on elm and an intel device. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id72291b2220e324cadb4241a2a6f8288ba579295 Reviewed-on: https://chromium-review.googlesource.com/620470 Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#496975} [modify] https://crrev.com/3244bc11b60f7478fc2adf93d85b21263470f395/media/gpu/BUILD.gn [modify] https://crrev.com/3244bc11b60f7478fc2adf93d85b21263470f395/media/gpu/jpeg_decode_accelerator_unittest.cc
,
Aug 24 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ad2427d7004609cbe998b947653dab41a464c72 commit 8ad2427d7004609cbe998b947653dab41a464c72 Author: Alexandre Courbot <acourbot@chromium.org> Date: Fri Aug 25 14:04:55 2017 media/gpu: restrict accelerated HW test to supported platforms HW accelerated tests are not supported on all Chrome OS platforms. Rather their availability is defined by the presence of a supported HW-accelerated API (VA-API or V4L2). Update the build conditions to reflect that fact. BUG= chromium:754442 TEST=verified that VDA, VDE and JDA tests build on supported platforms and are omitted on others. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7b8698f5b9d0be48368e872c0375b8a6609f9b86 Reviewed-on: https://chromium-review.googlesource.com/627958 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#497397} [modify] https://crrev.com/8ad2427d7004609cbe998b947653dab41a464c72/BUILD.gn [modify] https://crrev.com/8ad2427d7004609cbe998b947653dab41a464c72/media/gpu/BUILD.gn
,
Aug 25 2017
Marking as fixed since buildsystem-level fix has been merged. In addition hiroh@'s https://chromium-review.googlesource.com/c/chromium/src/+/620470 should also prevent compilation failures should that file be compiled on platforms not supporting JPEG acceleration again.
,
Nov 6 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dcheng@chromium.org
, Aug 10 2017