New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754391 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

UDL devices not working where drm-atomic is enabled.

Project Member Reported by dcasta...@chromium.org, Aug 10 2017

Issue description

crrev.com/d7d6b1b3f0dcce37e83e783feaac32c4f5a070b1 broke UDL devices on all the platforms where --enable-drm-atomic is passed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8920d3ae9a3a2e555127a3634c3140571017ea

commit bc8920d3ae9a3a2e555127a3634c3140571017ea
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Fri Aug 11 06:04:54 2017

Revert "ozone: Fail when atomic is requested but not supported."

crrev.com/d7d6b1b3f0dcce37e83e783feaac32c4f5a070b1 made DrmDevice
initialization fail if drm-atomic was requested but not supported.

This broke UDL devices (where atomic is not supported) on devices
were atomic is requested (rk3366 and kbl).

Bug:  754391 
Test: eve with mimo works again.
Change-Id: Ib35a25f03baa69d23c513e85a9f54cf3d609c44d
Reviewed-on: https://chromium-review.googlesource.com/611030
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493676}
[modify] https://crrev.com/bc8920d3ae9a3a2e555127a3634c3140571017ea/ui/ozone/platform/drm/gpu/drm_device.cc

Labels: -M-60 Merge-Request-61

Comment 3 by ketakid@google.com, Aug 11 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e21f614df5bfb6fa0bfe926ac91df6a52fb7a3a3

commit e21f614df5bfb6fa0bfe926ac91df6a52fb7a3a3
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Fri Aug 11 23:54:19 2017

Revert "ozone: Fail when atomic is requested but not supported."

crrev.com/d7d6b1b3f0dcce37e83e783feaac32c4f5a070b1 made DrmDevice
initialization fail if drm-atomic was requested but not supported.

This broke UDL devices (where atomic is not supported) on devices
were atomic is requested (rk3366 and kbl).

TBR=dcastagna@chromium.org

(cherry picked from commit bc8920d3ae9a3a2e555127a3634c3140571017ea)

Bug:  754391 
Test: eve with mimo works again.
Change-Id: Ib35a25f03baa69d23c513e85a9f54cf3d609c44d
Reviewed-on: https://chromium-review.googlesource.com/611030
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493676}
Reviewed-on: https://chromium-review.googlesource.com/612406
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#498}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e21f614df5bfb6fa0bfe926ac91df6a52fb7a3a3/ui/ozone/platform/drm/gpu/drm_device.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment