New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754389 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Switch from chart JSON to test result JSON for enabled/disabled indication

Project Member Reported by eakuefner@chromium.org, Aug 10 2017

Issue description

Currently, we use chart JSON to indicate whether Telemetry tests are enabled or disabled. However, we intend to switch Telemetry's primary output format to HistogramSet, which does not have support for enabled/disabled indication. Fortunately, we have recently started outputting Chromium's JSON test results format, which does have support for indicating enabled/disabled status of tests.

We want to switch to using the JSON test results format for this indication instead of chart JSON, so that we can safely switch the transit for performance results from chart JSON to HistogramSet. To do this, we should make use of the 'expected' and 'actual' fields of the result: if a test was skipped and was expected to have been skipped, then this implies that it was disabled.
 
Currently, we use chart JSON to indicate whether Telemetry tests are enabled or disabled.
Are we still doing this anywhere now that it's been removed from run_telemetry_benchmark_as_googletest?
It looks like PageTestResults gets it's enabled/disabled status from story expectations in story runner: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py?type=cs&l=299
Status: WontFix (was: Untriaged)
Ashley, you're right. As of https://chromium-review.googlesource.com/c/602068 it appears that we are in fact not using chart JSON's enabled bit any more. In that case, it seems like it's safe for me to switch to using histograms.

I'll close this bug.

Sign in to add a comment