New issue
Advanced search Search tips

Issue 754378 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Captive Portal detection on iOS needs to timeout after a reasonable delay

Project Member Reported by michaeldo@chromium.org, Aug 10 2017

Issue description

The captive portal detection may take a very long time. (see reference below) Since the display of the SSL error page or Captive Portal interstitial is dependent on the detection of the captive portal, there should be a reasonable timeout before the SSL error page is displayed.

See comment on iOS Captive Portal CL which brought up this issue here: https://chromium-review.googlesource.com/c/591691/2/ios/chrome/browser/ssl/ios_ssl_error_handler.mm
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc3974189d1043c594c7ddf120ba907019e0ae7

commit 8dc3974189d1043c594c7ddf120ba907019e0ae7
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Nov 10 01:40:52 2017

Add timeout to Captive Portal detection on iOS.

Captive portal detection may take a very long time in which case the SSL
error interstitial will be shown to the user instead of waiting to
determine the captive portal state.

Bug:  754378 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I31c982f581d4b1cb8b86dfb39c722955f6769cd6
Reviewed-on: https://chromium-review.googlesource.com/759169
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515406}
[modify] https://crrev.com/8dc3974189d1043c594c7ddf120ba907019e0ae7/ios/chrome/browser/ssl/BUILD.gn
[modify] https://crrev.com/8dc3974189d1043c594c7ddf120ba907019e0ae7/ios/chrome/browser/ssl/ios_ssl_error_handler.h
[modify] https://crrev.com/8dc3974189d1043c594c7ddf120ba907019e0ae7/ios/chrome/browser/ssl/ios_ssl_error_handler.mm
[modify] https://crrev.com/8dc3974189d1043c594c7ddf120ba907019e0ae7/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment