New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754374 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

WprGo doesn't support armv7l and aarch64

Project Member Reported by laszio@chromium.org, Aug 10 2017

Issue description

Traceback (most recent call last):
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 98, in _RunStoryAndProcessErrorIfNeeded
    state.WillRunStory(story)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 224, in WillRunStory
    archive_path, page.make_javascript_deterministic)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/core/network_controller.py", line 42, in StartReplay
    make_javascript_deterministic)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py", line 215, in StartReplay
    local_ports = self._StartReplayServer()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py", line 240, in _StartReplayServer
    replay_options=self._ReplayCommandLineArgs())
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py", line 83, in __init__
    py_utils.GetHostOsName())
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/util/binary_manager.py", line 76, in FetchPath
    binary_name, _GetOSName(os_name), arch, os_version)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 38, in FetchPath
    os_version)
  File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/binary_manager.py", line 60, in _WrapDependencyManagerFunction
    return function(binary_name, platform)
  File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 130, in FetchPath
    path, _ = self.FetchPathWithVersion(dependency, platform)
  File "/usr/local/telemetry/src/third_party/catapult/dependency_manager/dependency_manager/manager.py", line 89, in FetchPathWithVersion
    raise exceptions.NoPathFoundError(dependency, platform)
NoPathFoundError: No file could be found locally, and no file to download from cloud storage for wpr_go on platform linux_armv7l

 
Cc: -nednguyen@chromium.org nedngu...@google.com achuith@chromium.org
Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-2 Pri-1
Bumping to P1. 
This is blocking all of the toolchain's team ARM testing. Please fix it.
Owner: ----
Status: Untriaged (was: Assigned)
Sorry, I don't have time to look at this.
laszio@: What are the repo steps?

Comment 7 by laszio@chromium.org, Aug 23 2017

Steps to reproduce:

1. ssh into some ARM based chromebook.
2. (in chromebook) $ python /usr/local/telemetry/src/tools/perf/run_benchmark --browser=system kraken

Comment 8 by laszio@chromium.org, Aug 23 2017

Cc: gurcheta...@chromium.org sbasi@chromium.org
These 2 tests should also suffer. Copying people who worked on them.

telemetry_GpuTests
telemetry_ScrollingActionTests
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5a51638398691dee889202e043a42a30a6aef585

commit 5a51638398691dee889202e043a42a30a6aef585
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Aug 23 22:38:11 2017

Force all toolchain tests as run_local: False.

wprgo package is missing for arm32. So we cannot run these
tests locally till wprgo for arm32 is provided.

BUG= chromium:754374 
TEST=crosperf job is created with run_local:False

Change-Id: I6503017f9350684988305d8a7d6432574dab04d6
Reviewed-on: https://chromium-review.googlesource.com/629716
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/5a51638398691dee889202e043a42a30a6aef585/buildbot_test_toolchains.py

Owner: bccheng@chromium.org
Yup, these benchmarks can still be run remotely, so this works:
src/tools/perf/run_benchmark --browser=cros-chrome --remote=<DUT_IP> kraken

We don't have wpr for these architectures, so someone needs to compile wpr_go for these architectures (arm_v71, aarch64), upload to cloud storage, and add the cloud storage hash to this file:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/binary_dependencies.json?l=370-394


That file is updated using third_party/catapult/telemetry/bin/update_wpr_go_binary.
I am happy to do CL review. nednguyen@ is out of office currently.
Please take a look:
https://codereview.chromium.org/3004523004/
Thanks a lot!
Owner: laszio@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401f4be6da70906bebac1e8d51539bc277d03f9f

commit 401f4be6da70906bebac1e8d51539bc277d03f9f
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Aug 24 22:48:41 2017

Roll src/third_party/catapult/ cad1ea245..ab4d571fa (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cad1ea2451b7..ab4d571fa25e

$ git log cad1ea245..ab4d571fa --date=short --no-merges --format='%ad %ae %s'
2017-08-24 laszio wpr_go: support armv7l and aarch64

Created with:
  roll-dep src/third_party/catapult
BUG= 754374 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6dd709375ad51ee585c720b3942435e082b4eb56
Reviewed-on: https://chromium-review.googlesource.com/634252
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497230}
[modify] https://crrev.com/401f4be6da70906bebac1e8d51539bc277d03f9f/DEPS

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment