New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754371 link

Starred by 3 users
Status: Duplicate
Merged: issue 760316
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
einbinder@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 752617


Sign in to add a comment

Add ability to patch requests in devtools

Project Member Reported by allada@chromium.org, Aug 10 2017 
If a user modifies a CSS, HTML, Javascript file or similar file, the user should be able to let devtools persist the settings and patch the network request so the dev can see what the page would look like if the server served the request after modification.

Comment 2 by allada@chromium.org, Nov 10 2017

Mergedinto: 760316
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2

commit 7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Nov 15 01:54:28 2017

[Devtools] Requests can now be intercepted on response

Adds the ability in protocol to intercept requests on the response
instead of the request. This will allow us to patch requests instead of
just feed in the raw data.

R=pfeldman,dgozman,caseq,alexclarke
BUG= 754371 

Change-Id: Iabe83509d953a6a958c410d4c260e66582caf91a
Reviewed-on: https://chromium-review.googlesource.com/754007
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516556}
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_interceptor_controller.cc
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_interceptor_controller.h
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/content/browser/devtools/protocol_config.json
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-both-redirect-rewrite-expected.txt
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-both-redirect-rewrite.js
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response-expected.txt
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response-redirect-expected.txt
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response-redirect.js
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-on-response.js
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/simple-iframe.html
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/final.html
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/interception-test.js
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/redirect1.php
[add] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/redirect2.php
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/7c44d942b61a2f8ea63a0020ea1a4c907c6d98b2/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Comment 4 Deleted

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153

commit 5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153
Author: Nathan Bruer <allada@chromium.org>
Date: Sat Nov 18 03:20:41 2017

[Devtools] Overriders now handles long urls properly

In the event that a url once encoded is more than 200 characters we will
do partial hashing to it in order to ensure it plays well with operating
systems like windows which only supports ~255 character total length
paths.

R=lushnikov
BUG= 754371 

Change-Id: I6120ad13bff71a4933dd38088b81ecf480771360
Reviewed-on: https://chromium-review.googlesource.com/777602
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517689}
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety.js
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching.js
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/5dfcaa90d985c4f1c231a7f7d2d5f600a95a2153/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/832a9b3ef210685b16a5af3d3d352fea79f6368e

commit 832a9b3ef210685b16a5af3d3d352fea79f6368e
Author: Nathan Bruer <allada@chromium.org>
Date: Tue Nov 28 04:29:26 2017

[Devtools] Fixed overrides when navigating

Fixed bugs where if navigating pages it would sometimes not bind
properly and end up creating two files for every save.

R=lushnikov
BUG= 754371 

Change-Id: I6c978148ab7ff49e7f86f68ee246b6755e0c5e5c
Reviewed-on: https://chromium-review.googlesource.com/791812
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519566}
[modify] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety.js
[modify] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html.js
[modify] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash.js
[add] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind-expected.txt
[add] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind.js
[modify] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/OverridesTestRunner.js
[modify] https://crrev.com/832a9b3ef210685b16a5af3d3d352fea79f6368e/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f8c976999993c25f2412538306b4789061e2668

commit 1f8c976999993c25f2412538306b4789061e2668
Author: Nathan Bruer <allada@chromium.org>
Date: Thu Nov 30 20:16:06 2017

[Devtools] Changed files now ignored properly in workspaces

If a file is changed on the filesystem and is ignored in devtools it
will now properly not be created in workspaces.

R=lushnikov
BUG= 754371 

Change-Id: Ic0bc61ede57fb1aa17f1483f614bcca414fe14b6
Reviewed-on: https://chromium-review.googlesource.com/798735
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520659}
[add] https://crrev.com/1f8c976999993c25f2412538306b4789061e2668/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed-expected.txt
[add] https://crrev.com/1f8c976999993c25f2412538306b4789061e2668/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed.js
[modify] https://crrev.com/1f8c976999993c25f2412538306b4789061e2668/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/1f8c976999993c25f2412538306b4789061e2668/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystem.js
[modify] https://crrev.com/1f8c976999993c25f2412538306b4789061e2668/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystemManager.js
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fdf76b540df1b309d0e3378d75b4c03ee8704f3

commit 3fdf76b540df1b309d0e3378d75b4c03ee8704f3
Author: Nathan Bruer <allada@chromium.org>
Date: Thu Nov 30 21:38:34 2017

[Devtools] Remove overrides from enabled by default for beta

Disbles overrides by default.

TBR=pfeldman
BUG= 754371 

Change-Id: Icd88688a94842bd6ff96566d41e07f6615caae32
Reviewed-on: https://chromium-review.googlesource.com/801574
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520700}
[modify] https://crrev.com/3fdf76b540df1b309d0e3378d75b4c03ee8704f3/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0204c1b2b46de23e33907faeedfa5d9bc0a135e5

commit 0204c1b2b46de23e33907faeedfa5d9bc0a135e5
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Dec 01 19:16:38 2017

[Devtools] Overrides intercepts while navigating

Overrides will now change projects before the navigation happens
allowing it to rewrite requests when navigating cross-origin.

R=caseq,lushnikov,einbinder
BUG= 754371 

Change-Id: I0201a2a714c06bc7d4babb59e6d02b51c8e1f5e3
Reviewed-on: https://chromium-review.googlesource.com/799682
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521009}
[modify] https://crrev.com/0204c1b2b46de23e33907faeedfa5d9bc0a135e5/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/0204c1b2b46de23e33907faeedfa5d9bc0a135e5/content/browser/devtools/devtools_url_interceptor_request_job.h
[add] https://crrev.com/0204c1b2b46de23e33907faeedfa5d9bc0a135e5/third_party/WebKit/LayoutTests/http/tests/devtools/network/resources/redirect-cross-origin-empty-html.php
[add] https://crrev.com/0204c1b2b46de23e33907faeedfa5d9bc0a135e5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-main-resource-cross-origin-expected.txt
[add] https://crrev.com/0204c1b2b46de23e33907faeedfa5d9bc0a135e5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-main-resource-cross-origin.js
►

Sign in to add a comment