New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754367 link

Starred by 2 users
Status: Fixed
Owner:
█ rahulchaudhry@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros-go.eclass should support wildcards in package list

Project Member Reported by rahulchaudhry@chromium.org, Aug 10 2017 
See this change for a motivating example: https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/600996/4/dev-go/cdp/cdp-0.9.1.ebuild

Ideally, installing all protocols should be as simple as listing "github.com/mafredri/cdp/protocol/...".

This only needs to be supported for CROS_GO_PACKAGES. Not needed for CROS_GO_BINARIES.

The tricky part seems to be checking for missing dependencies of installed packages.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/100ec03e9b5b89a877a38068406f5234feaa1179

commit 100ec03e9b5b89a877a38068406f5234feaa1179
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Sep 08 04:21:44 2017

cros-go.eclass: add support for "..." wildcard in CROS_GO_PACKAGES.

Also update a few ebuilds to use the new wildcard support.

BUG= chromium:754367 
TEST='FEATURES=test emerge dev-go/cdp` works.
TEST='FEATURES=test emerge dev-go/protobuf` works
     (installs extra package "github.com/golang/protobuf/ptypes").
TEST='FEATURES=test emerge chromeos-base/tast-common` works
     (installs extra package "chromiumos/tast/common/host/test").

Change-Id: I5766486ee31b5eb13bee2cd85495611f0dd730f5
Reviewed-on: https://chromium-review.googlesource.com/655923
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/chromeos-base/tast-common/tast-common-9999.ebuild
[modify] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/dev-go/protobuf/protobuf-0.0.1.ebuild
[rename] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/dev-go/protobuf/protobuf-0.0.1-r9.ebuild
[add] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/dev-go/cdp/cdp-0.9.1-r1.ebuild
[modify] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/dev-go/cdp/cdp-0.9.1.ebuild
[modify] https://crrev.com/100ec03e9b5b89a877a38068406f5234feaa1179/eclass/cros-go.eclass

Comment 2 by rahulchaudhry@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment