ClientLayerTreeFrameSink takes in ~10 input parameters [1]. This needs to be cleaned up. We should introduce an InitParams [2] kind of thing here. Tentatively assigning to staraz@. cc'ing other folks who may be able to help. [1] https://cs.chromium.org/chromium/src/components/viz/client/client_layer_tree_frame_sink.h?l=28 [2] https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host.h?l=72
In progress CL: https://chromium-review.googlesource.com/c/chromium/src/+/625336
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48e1b3215598640a85be04bf06c176235e5415b8 commit 48e1b3215598640a85be04bf06c176235e5415b8 Author: Xu Xing <xing.xu@intel.com> Date: Mon Sep 25 10:48:01 2017 Simplify ClientLayerTreeFrameSink construction Add InitParams to simplify ClientLayerTreeFrameSink's construction. BUG= 754366 Change-Id: I163c474e25249163e1423ceee78b9bc09e22470d Reviewed-on: https://chromium-review.googlesource.com/625336 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504025} [modify] https://crrev.com/48e1b3215598640a85be04bf06c176235e5415b8/components/viz/client/client_layer_tree_frame_sink.cc [modify] https://crrev.com/48e1b3215598640a85be04bf06c176235e5415b8/components/viz/client/client_layer_tree_frame_sink.h [modify] https://crrev.com/48e1b3215598640a85be04bf06c176235e5415b8/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/48e1b3215598640a85be04bf06c176235e5415b8/content/renderer/render_thread_impl.cc [modify] https://crrev.com/48e1b3215598640a85be04bf06c176235e5415b8/ui/aura/mus/window_port_mus.cc
Comment 1 by enne@chromium.org
, Aug 17 2017